Re: [PATCH] Replace evrp use in loop versioning with ranger.

2021-07-30 Thread Aldy Hernandez via Gcc-patches
On 7/30/21 10:39 AM, Richard Sandiford wrote: Aldy Hernandez writes: On Mon, Jul 26, 2021 at 7:28 PM Richard Sandiford wrote: Aldy Hernandez writes: On Mon, Jul 26, 2021 at 4:18 PM Richard Sandiford wrote: Aldy Hernandez writes: This patch replaces the evrp_range_analyzer in the lo

Re: [PATCH] Replace evrp use in loop versioning with ranger.

2021-07-30 Thread Richard Sandiford via Gcc-patches
aste of time. > > My callgrind harness for performance testing wasn't able to pick up > enough samples to measure the time spent in > pass_loop_versioning::execute. I've seen this happen before with > passes that run too fast. I'm afraid I don't have enough cycles to

Re: [PATCH] Replace evrp use in loop versioning with ranger.

2021-07-27 Thread Aldy Hernandez via Gcc-patches
ously > be a waste of time. My callgrind harness for performance testing wasn't able to pick up enough samples to measure the time spent in pass_loop_versioning::execute. I've seen this happen before with passes that run too fast. I'm afraid I don't have enough cycles to co

Re: [PATCH] Replace evrp use in loop versioning with ranger.

2021-07-26 Thread Richard Sandiford via Gcc-patches
s we were doing in lv_dom_walker > with evrp's record_ranges_from_stmt. Only statements of interest are > queried. Sounds good. If the results are already cached then another level of caching (via the second bitmap I mentioned above) would obviously be a waste of time. > How ab

Re: [PATCH] Replace evrp use in loop versioning with ranger.

2021-07-26 Thread Aldy Hernandez via Gcc-patches
> > How expensive is the check? If the result is worth caching, perhaps > > we should have two bitmaps: the existing one, and one that records > > whether we've checked a particular SSA name. > > > > If the check is relatively cheap then that won't be worth it though. > > If you're asking about th

Re: [PATCH] Replace evrp use in loop versioning with ranger.

2021-07-26 Thread Aldy Hernandez via Gcc-patches
7;re no longer calculating ranges for each statement in the IL, as we were doing in lv_dom_walker with evrp's record_ranges_from_stmt. Only statements of interest are queried. How about this patch, pending tests? Aldy From 8a350003d950869499d729921008abdb491d3a5e Mon Sep 17 00:00:00 2001 From:

Re: [PATCH] Replace evrp use in loop versioning with ranger.

2021-07-26 Thread Richard Sandiford via Gcc-patches
Aldy Hernandez writes: > This patch replaces the evrp_range_analyzer in the loop versioning code > with an on-demand ranger. > > Everything was pretty straightforward, except that range_of_expr requires > a gimple statement as context to provide context aware ranges. I didn't see > a convient pla

[PATCH] Replace evrp use in loop versioning with ranger.

2021-07-24 Thread Aldy Hernandez via Gcc-patches
This patch replaces the evrp_range_analyzer in the loop versioning code with an on-demand ranger. Everything was pretty straightforward, except that range_of_expr requires a gimple statement as context to provide context aware ranges. I didn't see a convient place where the statement was saved, s