Re: [PATCH] Remove vectorizer reduction operand swapping

2019-09-25 Thread Christophe Lyon
On Wed, 25 Sep 2019 at 09:33, Richard Biener wrote: > > On Tue, 24 Sep 2019, Christophe Lyon wrote: > > > On Wed, 18 Sep 2019 at 20:11, Richard Biener wrote: > > > > > > > > > It shouldn't be neccessary. > > > > > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. > > > (SLP

Re: [PATCH] Remove vectorizer reduction operand swapping

2019-09-25 Thread Richard Biener
On Tue, 24 Sep 2019, Christophe Lyon wrote: > On Wed, 18 Sep 2019 at 20:11, Richard Biener wrote: > > > > > > It shouldn't be neccessary. > > > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. > > (SLP part testing separately) > > > > Richard. > > > > 2019-09-18 Richard B

Re: [PATCH] Remove vectorizer reduction operand swapping

2019-09-24 Thread Christophe Lyon
On Wed, 18 Sep 2019 at 20:11, Richard Biener wrote: > > > It shouldn't be neccessary. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. > (SLP part testing separately) > > Richard. > > 2019-09-18 Richard Biener > > * tree-vect-loop.c (vect_is_simple_reduction):

Re: [PATCH] Remove vectorizer reduction operand swapping

2019-09-20 Thread Richard Biener
On Fri, 20 Sep 2019, Rainer Orth wrote: > Hi Richard, > > > On Thu, 19 Sep 2019, Richard Sandiford wrote: > > > >> Richard Biener writes: > >> > It shouldn't be neccessary. > >> > >> SVE is the counter-example :-) But the fix is simpler than the code > >> you removed, so it's still a net win.

Re: [PATCH] Remove vectorizer reduction operand swapping

2019-09-20 Thread Rainer Orth
Hi Richard, > On Thu, 19 Sep 2019, Richard Sandiford wrote: > >> Richard Biener writes: >> > It shouldn't be neccessary. >> >> SVE is the counter-example :-) But the fix is simpler than the code >> you removed, so it's still a net win. > > Yeah, I meant it shouldn't be necessary to swap operand

Re: [PATCH] Remove vectorizer reduction operand swapping

2019-09-19 Thread Richard Biener
On Thu, 19 Sep 2019, Richard Sandiford wrote: > Richard Biener writes: > > It shouldn't be neccessary. > > SVE is the counter-example :-) But the fix is simpler than the code > you removed, so it's still a net win. Yeah, I meant it shouldn't be necessary to swap operands of the original scalar

Re: [PATCH] Remove vectorizer reduction operand swapping

2019-09-19 Thread Richard Sandiford
Richard Biener writes: > It shouldn't be neccessary. SVE is the counter-example :-) But the fix is simpler than the code you removed, so it's still a net win. Fixes various vect.exp and aarch64-sve.exp ICEs. OK if it passes proper testing? Thanks, Richard 2019-09-19 Richard Sandiford gc

[PATCH] Remove vectorizer reduction operand swapping

2019-09-18 Thread Richard Biener
It shouldn't be neccessary. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. (SLP part testing separately) Richard. 2019-09-18 Richard Biener * tree-vect-loop.c (vect_is_simple_reduction): Remove operand swapping. (vectorize_fold_left_reduction