Re: [PATCH] Remove unused libgfortran functions

2016-12-21 Thread FX
I followed up with the following patch, committed as revision 243841, removing the old _gfortran_ftell and renaming the modern _gfortran_ftell2. It was bootstrapped and regtested on x86_64-apple-darwin16.3.0. This is the last item from https://gcc.gnu.org/wiki/LibgfortranAbiCleanup

Re: [PATCH] Remove unused libgfortran functions

2016-12-20 Thread Janne Blomqvist
On Tue, Dec 20, 2016 at 11:31 AM, FX wrote: >> I don't understand. Why would it imply a 1:1 mapping of release series >> with major ABI versions? > > OK, I thought you meant to map libgfortran version numbers (libgfortran.so.7 > with GCC 7). If it’s the gfortran.map node names, I’m happy with tha

Re: [PATCH] Remove unused libgfortran functions

2016-12-20 Thread FX
> I don't understand. Why would it imply a 1:1 mapping of release series > with major ABI versions? OK, I thought you meant to map libgfortran version numbers (libgfortran.so.7 with GCC 7). If it’s the gfortran.map node names, I’m happy with that indeed. Attached patch regtested on x86_64-apple

Re: [PATCH] Remove unused libgfortran functions

2016-12-19 Thread Janne Blomqvist
On Mon, Dec 19, 2016 at 6:15 PM, FX wrote: >> Thanks, committed as r243799. > > I think something went wrong in your commit, as none of the “removed” files > were removed: https://gcc.gnu.org/viewvc/gcc?view=revision&revision=243799 Indeed, thanks for bringing it up. Fixed by r243804. -- Jann

Re: [PATCH] Remove unused libgfortran functions

2016-12-19 Thread FX
> Thanks, committed as r243799. I think something went wrong in your commit, as none of the “removed” files were removed: https://gcc.gnu.org/viewvc/gcc?view=revision&revision=243799 FX

Re: [PATCH] Remove unused libgfortran functions

2016-12-19 Thread Janne Blomqvist
On Mon, Dec 19, 2016 at 12:59 PM, FX wrote: >> Yes, I agree (in general, though I was thinking of making the new one >> "GFORTRAN_7" to match the release series). > > Given that there will not be a 1-to-1 mapping of release series with major > ABI versions (hopefully!), I don’t think this is a go

Re: [PATCH] Remove unused libgfortran functions

2016-12-19 Thread Janne Blomqvist
On Mon, Dec 19, 2016 at 4:44 PM, FX wrote: >> Now that the libgfortran ABI major version has been bumped, we can >> remove functions for which the frontend nowadays generates inline >> code. >> >> This removes the malloc, free, exponent, fraction, nearest, rrspacing, >> spacing, set_exponent and t

Re: [PATCH] Remove unused libgfortran functions

2016-12-19 Thread FX
> Now that the libgfortran ABI major version has been bumped, we can > remove functions for which the frontend nowadays generates inline > code. > > This removes the malloc, free, exponent, fraction, nearest, rrspacing, > spacing, set_exponent and transpose intrinsics. Also the unused > store_exe_

Re: [PATCH] Remove unused libgfortran functions

2016-12-19 Thread FX
> Yes, I agree (in general, though I was thinking of making the new one > "GFORTRAN_7" to match the release series). Given that there will not be a 1-to-1 mapping of release series with major ABI versions (hopefully!), I don’t think this is a good idea. It will make people confused. > There's

Re: [PATCH] Remove unused libgfortran functions

2016-12-16 Thread Steve Kargl
On Fri, Dec 16, 2016 at 07:46:01PM +0200, Janne Blomqvist wrote: > On Fri, Dec 16, 2016 at 4:02 PM, FX wrote: > > A few questions: > > > > 1. Regarding gfortran.map, shouldn’t we just flatten out all the symbols > > from GFORTRAN_1.0 to GFORTRAN_1.7 into a single new GFORTRAN_2.0 group > > (wh

Re: [PATCH] Remove unused libgfortran functions

2016-12-16 Thread Janne Blomqvist
On Fri, Dec 16, 2016 at 4:02 PM, FX wrote: > A few questions: > > 1. Regarding gfortran.map, shouldn’t we just flatten out all the symbols > from GFORTRAN_1.0 to GFORTRAN_1.7 into a single new GFORTRAN_2.0 group (while > removing the ones we are getting rid of)? Yes, I agree (in general, thou

Re: [PATCH] Remove unused libgfortran functions

2016-12-16 Thread FX
A few questions: 1. Regarding gfortran.map, shouldn’t we just flatten out all the symbols from GFORTRAN_1.0 to GFORTRAN_1.7 into a single new GFORTRAN_2.0 group (while removing the ones we are getting rid of)? 2. While we are breaking the ABI, shouldn’t we reorder the array argument to the

[PATCH] Remove unused libgfortran functions

2016-12-16 Thread Janne Blomqvist
Now that the libgfortran ABI major version has been bumped, we can remove functions for which the frontend nowadays generates inline code. This removes the malloc, free, exponent, fraction, nearest, rrspacing, spacing, set_exponent and transpose intrinsics. Also the unused store_exe_path function