Re: [PATCH] Remove unreachable code from get_ref_base_and_extent

2016-02-04 Thread Richard Biener
On February 4, 2016 8:50:58 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >As discussed on IRC and in the PR, get_ref_base_and_extent has >a big while (1) which can be only left with goto done;, so code >in between the end of that loop and the done: label is unreachable. >If the base is *MEM_REF, we

[PATCH] Remove unreachable code from get_ref_base_and_extent

2016-02-04 Thread Jakub Jelinek
Hi! As discussed on IRC and in the PR, get_ref_base_and_extent has a big while (1) which can be only left with goto done;, so code in between the end of that loop and the done: label is unreachable. If the base is *MEM_REF, we already set maxsize to -1, and for decls it really shouldn't be needed,