Re: [PATCH] Remove quite obvious dead assignments.

2019-06-27 Thread Richard Sandiford
Martin Liška writes: > On 6/26/19 1:39 PM, Jakub Jelinek wrote: >> On Wed, Jun 26, 2019 at 12:57:15PM +0200, Martin Liška wrote: >>> --- a/gcc/tree-vect-stmts.c >>> +++ b/gcc/tree-vect-stmts.c >>> @@ -3483,8 +3483,7 @@ vectorizable_call (stmt_vec_info stmt_info, >>> gimple_stmt_iterator *gsi, >>>

Re: [PATCH] Remove quite obvious dead assignments.

2019-06-27 Thread Martin Liška
c_stmt = new_stmt_info; > else > STMT_VINFO_RELATED_STMT (prev_stmt_info) = new_stmt_info; > prev_stmt_info = new_stmt_info; > otherwise. In any case, I think this should be dealt with separately. Likewise here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91017 I'

Re: [PATCH] Remove quite obvious dead assignments.

2019-06-26 Thread Jeff Law
On 6/26/19 4:57 AM, Martin Liška wrote: > Hi. > > I've spent some with clang-static-analyzer and I analyzed the warnings > reported. > As always wit analyzers, majority of the issues are false positives, however > it caught > couple of real issues: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?

Re: [PATCH] Remove quite obvious dead assignments.

2019-06-26 Thread Martin Jambor
Hi, On Wed, Jun 26 2019, Martin Liška wrote: > Hi. > > I've spent some with clang-static-analyzer and I analyzed the warnings > reported. > As always wit analyzers, majority of the issues are false positives, however > it caught > couple of real issues: > > https://gcc.gnu.org/bugzilla/show_bug.

Re: [PATCH] Remove quite obvious dead assignments.

2019-06-26 Thread Jakub Jelinek
On Wed, Jun 26, 2019 at 12:57:15PM +0200, Martin Liška wrote: > --- a/gcc/asan.c > +++ b/gcc/asan.c > @@ -1713,8 +1713,8 @@ asan_emit_allocas_unpoison (rtx top, rtx bot, rtx_insn > *before) >rtx ret = init_one_libfunc ("__asan_allocas_unpoison"); >top = convert_memory_address (ptr_mode, to

[PATCH] Remove quite obvious dead assignments.

2019-06-26 Thread Martin Liška
Hi. I've spent some with clang-static-analyzer and I analyzed the warnings reported. As always wit analyzers, majority of the issues are false positives, however it caught couple of real issues: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90973 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90978