Re: [PATCH] Remove can_throw_non_call_exceptions special case from operator_div::wi_fold.

2021-11-30 Thread Aldy Hernandez via Gcc-patches
Will adjust, re-test and commit. Thanks. Aldy On Tue, Nov 30, 2021 at 10:00 AM Richard Biener wrote: > > On Tue, Nov 30, 2021 at 9:51 AM Aldy Hernandez wrote: > > > > On Tue, Nov 30, 2021 at 8:37 AM Richard Biener > > wrote: > > > > > > On Mon, Nov 29, 2021 at 4:24 PM Aldy Hernandez wrote: >

Re: [PATCH] Remove can_throw_non_call_exceptions special case from operator_div::wi_fold.

2021-11-30 Thread Richard Biener via Gcc-patches
On Tue, Nov 30, 2021 at 9:51 AM Aldy Hernandez wrote: > > On Tue, Nov 30, 2021 at 8:37 AM Richard Biener > wrote: > > > > On Mon, Nov 29, 2021 at 4:24 PM Aldy Hernandez wrote: > > > > > > On Mon, Nov 29, 2021 at 3:48 PM Richard Biener > > > wrote: > > > > > > > > On Mon, Nov 29, 2021 at 3:39 PM

Re: [PATCH] Remove can_throw_non_call_exceptions special case from operator_div::wi_fold.

2021-11-30 Thread Aldy Hernandez via Gcc-patches
(at least) DCE, DSE, and the code sinking passes. > > I've fixed all 3 in the attached (untested) patch. Dunno what y'all > > want to do at this point. > > I think you need to add -fno-delete-dead-exceptions to the testcase. > The sinking > bug looks rea

Re: [PATCH] Remove can_throw_non_call_exceptions special case from operator_div::wi_fold.

2021-11-29 Thread Richard Biener via Gcc-patches
On Mon, Nov 29, 2021 at 4:24 PM Aldy Hernandez wrote: > > On Mon, Nov 29, 2021 at 3:48 PM Richard Biener > wrote: > > > > On Mon, Nov 29, 2021 at 3:39 PM Jeff Law wrote: > > > > > > > > > > > > On 11/29/2021 7:00 AM, Aldy Hernandez via Gcc-patches wrote: > > > > As discussed in the PR. The code

Re: [PATCH] Remove can_throw_non_call_exceptions special case from operator_div::wi_fold.

2021-11-29 Thread Aldy Hernandez via Gcc-patches
de sinking passes. I've fixed all 3 in the attached (untested) patch. Dunno what y'all want to do at this point. Aldy From c521bd22d4a7360c7b01f864392eb5cf68cfc6f0 Mon Sep 17 00:00:00 2001 From: Aldy Hernandez Date: Mon, 29 Nov 2021 12:52:45 +0100 Subject: [PATCH] Remove can_throw_n

Re: [PATCH] Remove can_throw_non_call_exceptions special case from operator_div::wi_fold.

2021-11-29 Thread Richard Biener via Gcc-patches
On Mon, Nov 29, 2021 at 3:39 PM Jeff Law wrote: > > > > On 11/29/2021 7:00 AM, Aldy Hernandez via Gcc-patches wrote: > > As discussed in the PR. The code makes no difference, so whatever test > > we added this special case for has been fixed or is being papered over. > > I think we should fix any

Re: [PATCH] Remove can_throw_non_call_exceptions special case from operator_div::wi_fold.

2021-11-29 Thread Jeff Law via Gcc-patches
On 11/29/2021 7:00 AM, Aldy Hernandez via Gcc-patches wrote: As discussed in the PR. The code makes no difference, so whatever test we added this special case for has been fixed or is being papered over. I think we should fix any fall out upstream. [Unless Andrew can remember why we added th

[PATCH] Remove can_throw_non_call_exceptions special case from operator_div::wi_fold.

2021-11-29 Thread Aldy Hernandez via Gcc-patches
As discussed in the PR. The code makes no difference, so whatever test we added this special case for has been fixed or is being papered over. I think we should fix any fall out upstream. [Unless Andrew can remember why we added this and it still applies.] Tested on x86-64 Linux. OK for trunk?