Re: [rfc] Fix SPU build (Re: [PATCH] Remove basic_block->loop_depth)

2012-08-15 Thread Ulrich Weigand
Richard Guenther wrote: > On Wed, 15 Aug 2012, Ulrich Weigand wrote: > > It seems flow_loops_find by itself is not quite enough, but everything > > necessary to use the loop structures seems to be encapsulated in > > loop_optimizer_init / loop_optimizer_finalize, which are already called > > by a n

Re: [rfc] Fix SPU build (Re: [PATCH] Remove basic_block->loop_depth)

2012-08-15 Thread Richard Guenther
On Wed, 15 Aug 2012, Ulrich Weigand wrote: > Richard Guenther wrote: > > On Tue, 14 Aug 2012, Ulrich Weigand wrote: > > > Looks like this broke SPU build, since spu_machine_dependent_reorg > > > accesses ->loop_depth. According to comments in the code, this > > > was done because of concerns that

[rfc] Fix SPU build (Re: [PATCH] Remove basic_block->loop_depth)

2012-08-15 Thread Ulrich Weigand
Richard Guenther wrote: > On Tue, 14 Aug 2012, Ulrich Weigand wrote: > > Looks like this broke SPU build, since spu_machine_dependent_reorg > > accesses ->loop_depth. According to comments in the code, this > > was done because of concerns that loop_father may no longer be set up > > this late in

Re: [PATCH] Remove basic_block->loop_depth

2012-08-14 Thread Richard Guenther
On Tue, 14 Aug 2012, Steven Bosscher wrote: > On Tue, Aug 14, 2012 at 12:48 PM, Richard Guenther wrote: > > If SPU md reorg would like to look at loop structures it should > > compute them. Simply call flow_loops_find, which hopefully works > > in CFG RTL mode (which I think is the mode availabl

Re: [PATCH] Remove basic_block->loop_depth

2012-08-14 Thread Steven Bosscher
On Tue, Aug 14, 2012 at 12:48 PM, Richard Guenther wrote: > If SPU md reorg would like to look at loop structures it should > compute them. Simply call flow_loops_find, which hopefully works > in CFG RTL mode (which I think is the mode available from md reorg?). No, the CFG is destroyed just bef

Re: [PATCH] Remove basic_block->loop_depth

2012-08-14 Thread Richard Guenther
On Tue, 14 Aug 2012, Ulrich Weigand wrote: > Richard Guenther wrote: > > > Accessing loop_depth (bb->loop_father) isn't very expensive. The > > following removes the duplicate info in basic-blocks which is not > > properly kept up-to-date at the moment. > > Looks like this broke SPU build, sinc

Re: [PATCH] Remove basic_block->loop_depth

2012-08-14 Thread Ulrich Weigand
Richard Guenther wrote: > Accessing loop_depth (bb->loop_father) isn't very expensive. The > following removes the duplicate info in basic-blocks which is not > properly kept up-to-date at the moment. Looks like this broke SPU build, since spu_machine_dependent_reorg accesses ->loop_depth. Acco

[PATCH] Remove basic_block->loop_depth

2012-08-13 Thread Richard Guenther
Accessing loop_depth (bb->loop_father) isn't very expensive. The following removes the duplicate info in basic-blocks which is not properly kept up-to-date at the moment. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2012-08-13 Richard Guenther * basic-blo