Re: [PATCH] Remove TARGET_GEN_MEMSET_SCRATCH_RTX since it's not used anymore.

2023-03-22 Thread H.J. Lu via Gcc-patches
On Wed, Mar 22, 2023 at 3:19 AM Richard Biener wrote: > > On Wed, Mar 22, 2023 at 8:07 AM Uros Bizjak wrote: > > > > On Wed, Mar 22, 2023 at 3:59 AM liuhongt wrote: > > > > > > The target hook is only used by i386, and the current definition is > > > same as default gen_reg_rtx. So there's no ne

Re: [PATCH] Remove TARGET_GEN_MEMSET_SCRATCH_RTX since it's not used anymore.

2023-03-22 Thread Jakub Jelinek via Gcc-patches
On Wed, Mar 22, 2023 at 11:18:33AM +0100, Richard Biener via Gcc-patches wrote: > Is/was the code ever exercised for non-x86? HJ, what was the reason to > abstract this? Initially the hook looked like rtx ix86_gen_scratch_sse_rtx (machine_mode mode) {   if (TARGET_SSE) return gen_rtx_REG (mod

Re: [PATCH] Remove TARGET_GEN_MEMSET_SCRATCH_RTX since it's not used anymore.

2023-03-22 Thread Richard Biener via Gcc-patches
On Wed, Mar 22, 2023 at 8:07 AM Uros Bizjak wrote: > > On Wed, Mar 22, 2023 at 3:59 AM liuhongt wrote: > > > > The target hook is only used by i386, and the current definition is > > same as default gen_reg_rtx. So there's no need for this target hook. > > > > Bootstrapped and regtested on x86_64

Re: [PATCH] Remove TARGET_GEN_MEMSET_SCRATCH_RTX since it's not used anymore.

2023-03-22 Thread Uros Bizjak via Gcc-patches
On Wed, Mar 22, 2023 at 3:59 AM liuhongt wrote: > > The target hook is only used by i386, and the current definition is > same as default gen_reg_rtx. So there's no need for this target hook. > > Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. > Ok for trunk(or GCC14)? > > gcc/ChangeLog:

[PATCH] Remove TARGET_GEN_MEMSET_SCRATCH_RTX since it's not used anymore.

2023-03-21 Thread liuhongt via Gcc-patches
The target hook is only used by i386, and the current definition is same as default gen_reg_rtx. So there's no need for this target hook. Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. Ok for trunk(or GCC14)? gcc/ChangeLog: * builtins.cc (builtin_memset_read_str): Replace