Re: [PATCH] RISC-V: fix build issue with gcc 4.9.x

2023-05-02 Thread Andrew Pinski via Gcc-patches
On Tue, May 2, 2023 at 5:38 PM Kito Cheng via Gcc-patches wrote: > > > >>> Pushed to trunk, thanks for catching that, that's definitely should > > >>> use log2 no matter C++03 or C++11, > > >>> but I think GCC allows the usage of C++11 according to > > >>> https://gcc.gnu.org/install/prerequisites

Re: [PATCH] RISC-V: fix build issue with gcc 4.9.x

2023-05-02 Thread Kito Cheng via Gcc-patches
> >>> Pushed to trunk, thanks for catching that, that's definitely should > >>> use log2 no matter C++03 or C++11, > >>> but I think GCC allows the usage of C++11 according to > >>> https://gcc.gnu.org/install/prerequisites.html :P > >> Yes, we should be able to use C++11. I'd like to get that to

Re: [PATCH] RISC-V: fix build issue with gcc 4.9.x

2023-05-02 Thread Romain Naour via Gcc-patches
Hi Kito, Le 02/05/2023 à 17:51, Kito Cheng a écrit : >>> Pushed to trunk, thanks for catching that, that's definitely should >>> use log2 no matter C++03 or C++11, >>> but I think GCC allows the usage of C++11 according to >>> https://gcc.gnu.org/install/prerequisites.html :P >> Yes, we should be

Re: [PATCH] RISC-V: fix build issue with gcc 4.9.x

2023-05-02 Thread Kito Cheng via Gcc-patches
> > Pushed to trunk, thanks for catching that, that's definitely should > > use log2 no matter C++03 or C++11, > > but I think GCC allows the usage of C++11 according to > > https://gcc.gnu.org/install/prerequisites.html :P > Yes, we should be able to use C++11. I'd like to get that to C++17 at >

Re: [PATCH] RISC-V: fix build issue with gcc 4.9.x

2023-05-02 Thread Jeff Law via Gcc-patches
On 5/2/23 08:31, Kito Cheng via Gcc-patches wrote: Hi Romain: Pushed to trunk, thanks for catching that, that's definitely should use log2 no matter C++03 or C++11, but I think GCC allows the usage of C++11 according to https://gcc.gnu.org/install/prerequisites.html :P Yes, we should be able

Re: [PATCH] RISC-V: fix build issue with gcc 4.9.x

2023-05-02 Thread Kito Cheng via Gcc-patches
Hi Romain: Pushed to trunk, thanks for catching that, that's definitely should use log2 no matter C++03 or C++11, but I think GCC allows the usage of C++11 according to https://gcc.gnu.org/install/prerequisites.html :P On Tue, May 2, 2023 at 8:22 PM Romain Naour via Gcc-patches wrote: > > GCC s

[PATCH] RISC-V: fix build issue with gcc 4.9.x

2023-05-02 Thread Romain Naour via Gcc-patches
GCC should still build with GCC 4.8.3 or newer [1] using C++03 by default. But a recent change in RISC-V port introduced a C++11 feature "std::log2" [2]. Use log2 from the C header, without the namespace [3]. [1] https://gcc.gnu.org/install/prerequisites.html [2] https://gcc.gnu.org/git/?p=gcc.g