RE: [PATCH] RISC-V: Optimize permutation codegen with vcompress

2023-07-11 Thread Li, Pan2 via Gcc-patches
-V: Optimize permutation codegen with vcompress On 7/11/23 00:38, juzhe.zh...@rivai.ai wrote: > From: Ju-Zhe Zhong > > This patch is to recognize specific permutation pattern which can be applied > compress approach. > > Consider this following case: > #include &g

Re: [PATCH] RISC-V: Optimize permutation codegen with vcompress

2023-07-11 Thread Jeff Law via Gcc-patches
On 7/11/23 00:38, juzhe.zh...@rivai.ai wrote: From: Ju-Zhe Zhong This patch is to recognize specific permutation pattern which can be applied compress approach. Consider this following case: #include typedef int8_t vnx64i __attribute__ ((vector_size (64))); #define MASK_64

Re: [PATCH] RISC-V: Optimize permutation codegen with vcompress

2023-07-11 Thread Robin Dapp via Gcc-patches
> MASK4 0, 5, 6, 7 also works definitely Sure :) My remark was that the tests are all(?) evenly split and a bit more variation would have been nice. Not that it doesn't work, I'm OK with it as is. Regards Robin

Re: Re: [PATCH] RISC-V: Optimize permutation codegen with vcompress

2023-07-11 Thread 钟居哲
: [PATCH] RISC-V: Optimize permutation codegen with vcompress > The compress optimization pattern has included all variety. > It's not necessary to force split (half/half), we can apply this compress > pattern to any variety of compress pattern. Yes, that's clear. I meant the t

Re: [PATCH] RISC-V: Optimize permutation codegen with vcompress

2023-07-11 Thread Robin Dapp via Gcc-patches
> The compress optimization pattern has included all variety. > It's not necessary to force split (half/half), we can apply this compress > pattern to any variety of compress pattern. Yes, that's clear. I meant the testcases are mostly designed like MASK4 1, 2, 6, 7 instead of variation like M

Re: Re: [PATCH] RISC-V: Optimize permutation codegen with vcompress

2023-07-11 Thread 钟居哲
17 To: juzhe.zhong; gcc-patches CC: rdapp.gcc; kito.cheng; kito.cheng; jeffreyalaw Subject: Re: [PATCH] RISC-V: Optimize permutation codegen with vcompress Hi Juzhe, looks good from my side, thanks. While going through it I thought of some related cases that we could still handle differently but I d

Re: [PATCH] RISC-V: Optimize permutation codegen with vcompress

2023-07-11 Thread Robin Dapp via Gcc-patches
Hi Juzhe, looks good from my side, thanks. While going through it I thought of some related cases that we could still handle differently but I didn't bother to formalize them for now. Most likely we already handle them in the shortest way anyway. I'm going to check on that when I find some time

[PATCH] RISC-V: Optimize permutation codegen with vcompress

2023-07-10 Thread juzhe . zhong
From: Ju-Zhe Zhong This patch is to recognize specific permutation pattern which can be applied compress approach. Consider this following case: #include typedef int8_t vnx64i __attribute__ ((vector_size (64))); #define MASK_64\