Re: [PATCH] RISC-V: Fix unordered float compare for Signaling NaN.

2018-10-05 Thread Jim Wilson
On Fri, Oct 5, 2018 at 9:44 AM Jim Wilson wrote: > With a modified version of Andrew's patch, the testcase in Kito's > patch works, and I see the glibc testsuite failures drop from 151 to > 131, so there is still something wrong. Last time I ran the glibc > testsuite we were around 50-60 failures

Re: [PATCH] RISC-V: Fix unordered float compare for Signaling NaN.

2018-10-05 Thread Jim Wilson
On Wed, Oct 3, 2018 at 11:37 AM Jim Wilson wrote: > Thanks. I see that the rs6000.md port has a pattern that checks > HONOR_SNANS which looks like the right way to solve this problem. I > will try modifying Andrew's patch to use that and check against the > glibc testsuite. With a modified vers

Re: [PATCH] RISC-V: Fix unordered float compare for Signaling NaN.

2018-10-03 Thread Jim Wilson
On Wed, Oct 3, 2018 at 3:46 AM Joseph Myers wrote: > We already have -fsignaling-nans, if implementing the semantics of some > operation in a way that works with signaling NaNs is more expensive than > implementing them in a way that doesn't handle signaling NaNs correctly. > The glibc tests in qu

Re: [PATCH] RISC-V: Fix unordered float compare for Signaling NaN.

2018-10-03 Thread Joseph Myers
On Wed, 3 Oct 2018, Jim Wilson wrote: > That change wasn't committed at the time because it reduces > performance for everyone, even though only a few people depend on the > exact semantics the patch provides. One possible solution to that is > to add a -mieee option for people that want better I

Re: [PATCH] RISC-V: Fix unordered float compare for Signaling NaN.

2018-10-02 Thread Kito Cheng
Hi Jim: Oh, I missed that pull request in github, Andrew's patch is better than our patch, you can just ignore our one. However I think this fix is kind of pre-requirement of rv32 glibc upstreaming, because Joseph want new port has all passed testsuite result. On Wed, Oct 3, 2018 at 10:46 AM Jim W

Re: [PATCH] RISC-V: Fix unordered float compare for Signaling NaN.

2018-10-02 Thread Jim Wilson
On Tue, Oct 2, 2018 at 7:23 PM Kito Cheng wrote: > This patch is fixing the wrong behavior for unordered float compare > for Signaling NaN, current implementation will suppress the FP > exception flags unconditionally, however signaling NaN should signal > an exception according IEEE 754-2008 spec

[PATCH] RISC-V: Fix unordered float compare for Signaling NaN.

2018-10-02 Thread Kito Cheng
: Fri, 14 Sep 2018 16:25:45 +0800 Subject: [PATCH] RISC-V: Fix unordered float compare for signaling NaN. - Old implementation will suppress the FP exception flags unconditionally, however signaling NaN should signal an exception according IEEE 754-2008 spec. ChangeLog: 2018-10-03 Monk C