Re: [PATCH] RISC-V/testsuite: Fix ILP32 RVV failures from missing

2023-09-29 Thread Jeff Law
On 9/28/23 03:46, Maciej W. Rozycki wrote: On Wed, 27 Sep 2023, Jeff Law wrote: IMO this is one of those places where we should just be as normal as possible.  So if the other big ports allow system headers then we should, otherwise we should move everyone over to testing in some way we'll c

Re: [PATCH] RISC-V/testsuite: Fix ILP32 RVV failures from missing

2023-09-28 Thread Maciej W. Rozycki
On Wed, 27 Sep 2023, Jeff Law wrote: > > IMO this is one of those places where we should just be as normal as > > possible.  So if the other big ports allow system headers then we should, > > otherwise we should move everyone over to testing in some way we'll catch > > these before commit. > Exact

Re: [PATCH] RISC-V/testsuite: Fix ILP32 RVV failures from missing

2023-09-27 Thread Jeff Law
On 9/27/23 11:32, Palmer Dabbelt wrote: IMO this is one of those places where we should just be as normal as possible.  So if the other big ports allow system headers then we should, otherwise we should move everyone over to testing in some way we'll catch these before commit. Exactly. I

Re: [PATCH] RISC-V/testsuite: Fix ILP32 RVV failures from missing

2023-09-27 Thread Palmer Dabbelt
On Wed, 27 Sep 2023 10:28:55 PDT (-0700), jeffreya...@gmail.com wrote: On 9/25/23 15:17, Maciej W. Rozycki wrote: On Mon, 25 Sep 2023, Maciej W. Rozycki wrote: NB the use of this specific header, still in place elsewhere, seems gratuitous to me. We don't need or indeed want to print anyt

Re: [PATCH] RISC-V/testsuite: Fix ILP32 RVV failures from missing

2023-09-27 Thread Jeff Law
On 9/25/23 15:17, Maciej W. Rozycki wrote: On Mon, 25 Sep 2023, Maciej W. Rozycki wrote: NB the use of this specific header, still in place elsewhere, seems gratuitous to me. We don't need or indeed want to print anything in the test cases (unless verifying something specific to the prin

Re: [PATCH] RISC-V/testsuite: Fix ILP32 RVV failures from missing

2023-09-26 Thread Maciej W. Rozycki
On Fri, 22 Sep 2023, Jeff Law wrote: > > gcc/testsuite/ > > * gcc.target/riscv/rvv/autovec/vmv-imm-template.h: Remove > > inclusion. > OK Now committed, thanks. Maciej

Re: [PATCH] RISC-V/testsuite: Fix ILP32 RVV failures from missing

2023-09-25 Thread Maciej W. Rozycki
On Mon, 25 Sep 2023, Maciej W. Rozycki wrote: > NB the use of this specific header, still in place elsewhere, > seems gratuitous to me. We don't need or indeed want to print anything in > the test cases (unless verifying something specific to the print facility) > and if we want to avoid min

Re: [PATCH] RISC-V/testsuite: Fix ILP32 RVV failures from missing

2023-09-25 Thread Maciej W. Rozycki
On Sun, 24 Sep 2023, Vineet Gupta wrote: > This fix is great but is there a more general solution to the problem when we > toolchain is built for say just rv64 (and thus only those headers) vs. test > building for say rv32 (and failing to build due to lack of headers) or > vice-versa. The MIPS p

Re: [PATCH] RISC-V/testsuite: Fix ILP32 RVV failures from missing

2023-09-24 Thread Vineet Gupta
+CC Patrick who's been chasing similar issues. On 9/23/23 00:18, Maciej W. Rozycki wrote: In non-multilib installations system headers may not be available for compilation options using a non-default model, causing build errors such as: In file included from .../include/features.h:527,

Re: [PATCH] RISC-V/testsuite: Fix ILP32 RVV failures from missing

2023-09-22 Thread Jeff Law
On 9/22/23 17:18, Maciej W. Rozycki wrote: In non-multilib installations system headers may not be available for compilation options using a non-default model, causing build errors such as: In file included from .../include/features.h:527, from .../include/assert.h:35,

[PATCH] RISC-V/testsuite: Fix ILP32 RVV failures from missing

2023-09-22 Thread Maciej W. Rozycki
In non-multilib installations system headers may not be available for compilation options using a non-default model, causing build errors such as: In file included from .../include/features.h:527, from .../include/assert.h:35, from .../gcc/testsuite/gcc.target/