Re: [PATCH] RFC: Preserving locations for variable-uses and constants (PR 43486)

2017-11-02 Thread Jason Merrill
On Tue, Oct 31, 2017 at 5:09 PM, David Malcolm wrote: > On Tue, 2017-10-24 at 09:53 -0400, Jason Merrill wrote: >> On Fri, Oct 20, 2017 at 5:53 PM, David Malcolm >> wrote: >> > Design questions: >> > >> > * The patch introduces a new kind of tree node, currently called >> > DECL_WRAPPER_EXPR (a

Re: [PATCH] RFC: Preserving locations for variable-uses and constants (PR 43486)

2017-10-31 Thread David Malcolm
On Tue, 2017-10-24 at 09:53 -0400, Jason Merrill wrote: > On Fri, Oct 20, 2017 at 5:53 PM, David Malcolm > wrote: > > Design questions: > > > > * The patch introduces a new kind of tree node, currently called > > DECL_WRAPPER_EXPR (although it's used for wrapping constants as > > well > > as

Re: [PATCH] RFC: Preserving locations for variable-uses and constants (PR 43486)

2017-10-24 Thread Jason Merrill
On Fri, Oct 20, 2017 at 5:53 PM, David Malcolm wrote: > Design questions: > > * The patch introduces a new kind of tree node, currently called > DECL_WRAPPER_EXPR (although it's used for wrapping constants as well > as decls). Should wrappers be a new kind of tree node, or should they > reu

[PATCH] RFC: Preserving locations for variable-uses and constants (PR 43486)

2017-10-20 Thread David Malcolm
[following up on a discussion at Cauldron] This is a work-in-progress attempt at retaining source-location information for uses of variables and for constants: the tree nodes that don't have an EXPR_LOCATION in our internal representation. I'm posting the patch now to check that my approach is co