Re: [PATCH] RFC: On-demand locations within string-literals

2016-08-23 Thread Martin Sebor
On 08/23/2016 07:59 AM, David Malcolm wrote: On Mon, 2016-08-22 at 21:25 -0600, Martin Sebor wrote: Beyond that, the range normally works fine, except when macros are involved like they are in my tests. You can see the effect in the range.out file. (This works without your patch but it could v

Re: [PATCH] RFC: On-demand locations within string-literals

2016-08-23 Thread David Malcolm
On Mon, 2016-08-22 at 21:25 -0600, Martin Sebor wrote: > > > Beyond that, the range normally works fine, except when macros > > > are involved like they are in my tests. You can see the effect > > > in the range.out file. (This works without your patch but it > > > could very well be because I di

Re: [PATCH] RFC: On-demand locations within string-literals

2016-08-22 Thread Martin Sebor
Beyond that, the range normally works fine, except when macros are involved like they are in my tests. You can see the effect in the range.out file. (This works without your patch but it could very well be because I didn't set it up right.) Sadly I can't figure out what's going wrong - but the

Re: [PATCH] RFC: On-demand locations within string-literals

2016-07-23 Thread David Malcolm
On Sat, 2016-07-23 at 15:35 -0600, Martin Sebor wrote: > On 07/08/2016 03:49 PM, David Malcolm wrote: > > This patch implements precise tracking of source locations for the > > individual chars within string literals, so that we can e.g. > > underline > > specific ranges in -Wformat diagnostics. >

Re: [PATCH] RFC: On-demand locations within string-literals

2016-07-23 Thread Martin Sebor
On 07/08/2016 03:49 PM, David Malcolm wrote: This patch implements precise tracking of source locations for the individual chars within string literals, so that we can e.g. underline specific ranges in -Wformat diagnostics. ... Successfully bootstrapped®rtested on x86_64-pc-linux-gnu. Thoughts

Re: [PATCH] RFC: On-demand locations within string-literals

2016-07-21 Thread Jeff Law
On 07/20/2016 01:38 PM, David Malcolm wrote: On Fri, 2016-07-08 at 17:49 -0400, David Malcolm wrote: [...] Also, this patch currently makes the assumption (in charset.c) that there's a 1:1 correspondence between bytes in the source character set and bytes in the execution character set. This c

Re: [PATCH] RFC: On-demand locations within string-literals

2016-07-20 Thread David Malcolm
On Fri, 2016-07-08 at 17:49 -0400, David Malcolm wrote: [...] > Also, this patch currently makes the assumption (in charset.c) > that there's a 1:1 correspondence between bytes in the source > character set and bytes in the execution character set. This can > be the case if both are, say, UTF-8,

[PATCH] RFC: On-demand locations within string-literals

2016-07-08 Thread David Malcolm
This patch implements precise tracking of source locations for the individual chars within string literals, so that we can e.g. underline specific ranges in -Wformat diagnostics. It should also enable fixing PR inline-asm/57950 ("wrong line numbers in error messages for inline assembler statements