Re: [PATCH] Quash Wbool-compare warning in optabs.c

2014-08-19 Thread Richard Henderson
On 08/19/2014 08:54 AM, Marek Polacek wrote: > Works as well. So is the following ok once the regtest finishes? > > Bootstrapped on x86_64-linux. > > 2014-08-19 Marek Polacek > > * config/alpha/alpha.h (CLZ_DEFINED_VALUE_AT_ZERO, > CTZ_DEFINED_VALUE_AT_ZERO): Return 0/1 rather th

Re: [PATCH] Quash Wbool-compare warning in optabs.c

2014-08-19 Thread Marek Polacek
On Tue, Aug 19, 2014 at 07:52:33AM -0700, Richard Henderson wrote: > On 08/19/2014 07:12 AM, Marek Polacek wrote: > > On some archs, C[TL]Z_DEFINED_VALUE_AT_ZERO macros return only > > true/false, so -Wbool-compare would warn. > > Then we should fix them to return 0/1 instead. Works as well. So

Re: [PATCH] Quash Wbool-compare warning in optabs.c

2014-08-19 Thread Richard Henderson
On 08/19/2014 07:12 AM, Marek Polacek wrote: > On some archs, C[TL]Z_DEFINED_VALUE_AT_ZERO macros return only > true/false, so -Wbool-compare would warn. Then we should fix them to return 0/1 instead. r~

[PATCH] Quash Wbool-compare warning in optabs.c

2014-08-19 Thread Marek Polacek
On some archs, C[TL]Z_DEFINED_VALUE_AT_ZERO macros return only true/false, so -Wbool-compare would warn. But on e.g. mips or aarch64 they might yield 2. This patch casts the value to int to quash that warning. Dropping the "== 2" would be prettier, but I don't want to break other archs. The poin