Re: [PATCH] Prevent IPA-SRA from creating calls to local comdats (PR 92676)

2020-04-02 Thread Martin Jambor
Hi, On Fri, Mar 20 2020, Jan Hubicka wrote: > [...] > > OK except for ... >> @@ -3759,8 +3778,12 @@ process_isra_node_results (cgraph_node *node, >> = node->create_virtual_clone (callers, NULL, new_adjustments, "isra", >>suffix_counter); >>suffix_counter+

Re: [PATCH] Prevent IPA-SRA from creating calls to local comdats (PR 92676)

2020-03-20 Thread Jan Hubicka
> Hi, > > since r278669 (fix for PR ipa/91956), IPA-SRA makes sure that the clone > it creates is put into the same same_comdat as the original cgraph_node, > so that it can call private comdats (such as the ipa-split bits of a > comdat that is private). > > However, that means that if there is n

Re: [PATCH] Prevent IPA-SRA from creating calls to local comdats (PR 92676)

2020-03-11 Thread Martin Jambor
Hello, ping. Thanks, Martin On Mon, Dec 16 2019, Martin Jambor wrote: > Hi, > > since r278669 (fix for PR ipa/91956), IPA-SRA makes sure that the clone > it creates is put into the same same_comdat as the original cgraph_node, > so that it can call private comdats (such as the ipa-split bits o

Re: [PATCH] Prevent IPA-SRA from creating calls to local comdats (PR 92676)

2020-02-03 Thread Martin Jambor
Hello Honza, ping. Thanks, Martin On Mon, Dec 16 2019, Martin Jambor wrote: > Hi, > > since r278669 (fix for PR ipa/91956), IPA-SRA makes sure that the clone > it creates is put into the same same_comdat as the original cgraph_node, > so that it can call private comdats (such as the ipa-split

Re: [PATCH] Prevent IPA-SRA from creating calls to local comdats (PR 92676)

2020-01-09 Thread Martin Jambor
Ping. Thanks, Martin On Mon, Dec 16 2019, Martin Jambor wrote: > Hi, > > since r278669 (fix for PR ipa/91956), IPA-SRA makes sure that the clone > it creates is put into the same same_comdat as the original cgraph_node, > so that it can call private comdats (such as the ipa-split bits of a > com

[PATCH] Prevent IPA-SRA from creating calls to local comdats (PR 92676)

2019-12-16 Thread Martin Jambor
Hi, since r278669 (fix for PR ipa/91956), IPA-SRA makes sure that the clone it creates is put into the same same_comdat as the original cgraph_node, so that it can call private comdats (such as the ipa-split bits of a comdat that is private). However, that means that if there is non-comdat caller