Re: [PATCH] PowerPC section type conflict (created PR 51623)

2011-12-29 Thread Michael Meissner
On Wed, Dec 28, 2011 at 12:34:25PM -0800, Richard Henderson wrote: > On 12/28/2011 09:39 AM, Michael Meissner wrote: > > && in_section != text_section > > - && !unlikely_text_section_p (in_section) > > + && (in_section && (in_section->common.flags & SECTION_CODE)) == 0 > > You should

Re: [PATCH] PowerPC section type conflict (created PR 51623)

2011-12-28 Thread Michael Meissner
On Wed, Dec 28, 2011 at 12:34:25PM -0800, Richard Henderson wrote: > On 12/28/2011 09:39 AM, Michael Meissner wrote: > > && in_section != text_section > > - && !unlikely_text_section_p (in_section) > > + && (in_section && (in_section->common.flags & SECTION_CODE)) == 0 > > You should

Re: [PATCH] PowerPC section type conflict (created PR 51623)

2011-12-28 Thread Richard Henderson
On 12/28/2011 09:39 AM, Michael Meissner wrote: > && in_section != text_section > - && !unlikely_text_section_p (in_section) > + && (in_section && (in_section->common.flags & SECTION_CODE)) == 0 You should be able to delete the text_section test as well, and in_section should *

Re: [PATCH] PowerPC section type conflict (created PR 51623)

2011-12-28 Thread Michael Meissner
On Mon, Dec 19, 2011 at 11:45:35PM +0800, Chung-Lin Tang wrote: > On 2011/12/19 上午 03:18, Richard Henderson wrote: > > On 12/17/2011 10:36 PM, Chung-Lin Tang wrote: > >> I don't think it's that kind of problem; the powerpc backend uses > >> unlikely_text_section_p(), which compares the passed in ar

Re: [PATCH] PowerPC section type conflict (created PR 51623)

2011-12-19 Thread Chung-Lin Tang
On 2011/12/19 上午 03:18, Richard Henderson wrote: > On 12/17/2011 10:36 PM, Chung-Lin Tang wrote: >> I don't think it's that kind of problem; the powerpc backend uses >> unlikely_text_section_p(), which compares the passed in argument section >> and the value of function_section_1(current_function_d

Re: [PATCH] PowerPC section type conflict

2011-12-18 Thread Richard Henderson
On 12/17/2011 10:36 PM, Chung-Lin Tang wrote: > I don't think it's that kind of problem; the powerpc backend uses > unlikely_text_section_p(), which compares the passed in argument section > and the value of function_section_1(current_function_decl,true). I think this might be the real bug, or som

Re: [PATCH] PowerPC section type conflict

2011-12-17 Thread Chung-Lin Tang
On 2011/12/17 06:21 AM, Richard Henderson wrote: > On 12/16/2011 03:16 AM, Chung-Lin Tang wrote: >> Hi, under powerpc targets, using -mrelocatable under some cases triggers >> an error during final assembly generation: rs6000_assemble_integer() >> calls varasm.c:unlikely_text_section_p(), and the c

Re: [PATCH] PowerPC section type conflict

2011-12-16 Thread Richard Henderson
On 12/16/2011 03:16 AM, Chung-Lin Tang wrote: > Hi, under powerpc targets, using -mrelocatable under some cases triggers > an error during final assembly generation: rs6000_assemble_integer() > calls varasm.c:unlikely_text_section_p(), and the call chain eventually > gets to where the section htab

[PATCH] PowerPC section type conflict

2011-12-16 Thread Chung-Lin Tang
Hi, under powerpc targets, using -mrelocatable under some cases triggers an error during final assembly generation: rs6000_assemble_integer() calls varasm.c:unlikely_text_section_p(), and the call chain eventually gets to where the section htab is queried for ".text.unlikely", and fails because of