Re: [PATCH] PowerPC Prefixed Memory, Patch #3, Update predicates

2019-06-28 Thread Michael Meissner
On Fri, Jun 28, 2019 at 08:20:35AM -0500, Segher Boessenkool wrote: > Hi Mike, > > On Thu, Jun 27, 2019 at 08:12:35PM -0400, Michael Meissner wrote: > > + return (TARGET_CMODEL == CMODEL_MEDIUM && SYMBOL_REF_P (op) > > + && SYMBOL_REF_LOCAL_P (op)); > > Please break the line before that firs

Re: [PATCH] PowerPC Prefixed Memory, Patch #3, Update predicates

2019-06-28 Thread Bill Schmidt
On 6/28/19 8:20 AM, Segher Boessenkool wrote: > Hi Mike, > > On Thu, Jun 27, 2019 at 08:12:35PM -0400, Michael Meissner wrote: >> + return (TARGET_CMODEL == CMODEL_MEDIUM && SYMBOL_REF_P (op) >> + && SYMBOL_REF_LOCAL_P (op)); > Please break the line before that first && as well? > >> +(define

Re: [PATCH] PowerPC Prefixed Memory, Patch #3, Update predicates

2019-06-28 Thread Segher Boessenkool
Hi Mike, On Thu, Jun 27, 2019 at 08:12:35PM -0400, Michael Meissner wrote: > + return (TARGET_CMODEL == CMODEL_MEDIUM && SYMBOL_REF_P (op) > + && SYMBOL_REF_LOCAL_P (op)); Please break the line before that first && as well? > +(define_predicate "pcrel_external_address" > + (match_code "s

[PATCH] PowerPC Prefixed Memory, Patch #3, Update predicates

2019-06-27 Thread Michael Meissner
This patch updates the predicates for prefixed addressing. This patch deletes a predicate that I had originally added, but the code no longer uses. This patch changes how local symbols for pc-relative addressing are marked. Previously, we had used a machine dependent bit in the SYMBOL_REF node.