On Mon, 7 Jul 2014, David Edelsohn wrote:
> Yes, that's good. It helps if someone reading the code doesn't need to
> reverse engineer the numbering convention of the name.
Sure, I haven't questioned your request. Thanks for your review, applied
now.
Maciej
On Mon, Jul 7, 2014 at 10:33 AM, Maciej W. Rozycki
wrote:
>> Could you add a short comment explaining what the "0" and "1" labels
>> in vec_perm[01][01]_v2si mean?
>
> Like this?
>
> Maciej
>
> gcc-ppc-spe-le-update.diff
> Index: gcc-fsf-trunk-quilt/gcc/config/rs6000/spe.md
> =
On Mon, 7 Jul 2014, David Edelsohn wrote:
> gcc/
> * config/rs6000/rs6000.c (output_vec_const_move): Handle
> little-endian code generation.
> * config/rs6000/spe.md (spe_evmergehi): Rename to...
> (vec_perm00_v2si): ... this. Handle little-endian code
> generation.
> (spe_evmergehilo): Rename to
2014-07-07 Maciej W. Rozycki
gcc/
* config/rs6000/rs6000.c (output_vec_const_move): Handle
little-endian code generation.
* config/rs6000/spe.md (spe_evmergehi): Rename to...
(vec_perm00_v2si): ... this. Handle little-endian code
generation.
(spe_evmergehilo): Rename to...
(vec_perm01_v2si): .
Hi,
This change implements little-endian code generation for Signal
Processing Engine (SPE) operations.
Where possible changes are handled within the existing patterns with
suitable conditionals added to support the little-endian mode.
In some cases operand constraints are different between