Re: Ping: [PATCH] PR88395 Fix Nullptr when compiling with -fconcepts

2019-06-12 Thread Jason Merrill
On 6/5/19 10:17 AM, Richard Sandiford wrote: Thanks for the patch and sorry that there was no response. I've added the C++ maintainers to cc: Thanks. In the future, mentioning C++ in the subject line will help me see it. On 2019-04-08 7:20 p.m., Nicholas Krause wrote: This fixes the calle

Re: Ping: [PATCH] PR88395 Fix Nullptr when compiling with -fconcepts

2019-06-05 Thread Richard Sandiford
Thanks for the patch and sorry that there was no response. I've added the C++ maintainers to cc: nick writes: > I'm pinging this patch as it's old now and should be applied to fix the bug. > > Nick > > On 2019-04-08 7:20 p.m., Nicholas Krause wrote: >> This fixes the caller in tsubst_requires_exp

Ping: [PATCH] PR88395 Fix Nullptr when compiling with -fconcepts

2019-04-25 Thread nick
I'm pinging this patch as it's old now and should be applied to fix the bug. Nick On 2019-04-08 7:20 p.m., Nicholas Krause wrote: > This fixes the caller in tsubst_requires_expr to > tsubst_constraint_variables to wrap their respective > trees in PARM_CONSTR_PARMS. This is to get the correct > pa

[PATCH] PR88395 Fix Nullptr when compiling with -fconcepts

2019-04-08 Thread Nicholas Krause
This fixes the caller in tsubst_requires_expr to tsubst_constraint_variables to wrap their respective trees in PARM_CONSTR_PARMS. This is to get the correct parmeter constraints from the tree before calling tsubst_constraint_variables like other callers in constraint.cc and to fix the bug id, 88395

[PATCH] PR88395 Fix Nullptr when compiling with -fconcepts

2019-04-08 Thread Nicholas Krause
This fixes both callers in tsubst_requires_expr to tsubst_constraint_variables to wrap their respective trees in PARM_CONSTR_PARMS. This is to get the correct parmeter constraints from the tree before calling tsubst_constraint_variables like other callers in constraint.cc and to fix the bug id, 883

[PATCH] PR88395 Fix Nullptr when compiling with -fconcepts

2019-03-27 Thread Nicholas Krause
This fixes bug id,88395 by checking if the second tree reqs is correctly not a null pointer before calling the function, tsubst_requirement_body. Otherwise we will get a nullptr if compiling with -fconcepts for concepts enabled. Signed-off-by: Nicholas Krause --- gcc/cp/constraint.cc | 2 ++ 1 f