Re: [PATCH] PR86844: Fix for store merging

2018-09-11 Thread Andreas Krebbel
On 10.09.2018 19:53, Jakub Jelinek wrote: > On Mon, Sep 10, 2018 at 04:05:26PM +0200, Andreas Krebbel wrote: >> On 20.08.2018 16:30, Jeff Law wrote: >>> On 08/18/2018 03:20 AM, Eric Botcazou wrote: > Eric, didn't your patches explicitely handle this case of a non-constant > inbetween?

Re: [PATCH] PR86844: Fix for store merging

2018-09-10 Thread Jakub Jelinek
On Mon, Sep 10, 2018 at 04:05:26PM +0200, Andreas Krebbel wrote: > On 20.08.2018 16:30, Jeff Law wrote: > > On 08/18/2018 03:20 AM, Eric Botcazou wrote: > >>> Eric, didn't your patches explicitely handle this case of a non-constant > >>> inbetween? > >> > >> Only if there is no overlap at all, othe

Re: [PATCH] PR86844: Fix for store merging

2018-09-10 Thread Andreas Krebbel
On 20.08.2018 16:30, Jeff Law wrote: > On 08/18/2018 03:20 AM, Eric Botcazou wrote: >>> Eric, didn't your patches explicitely handle this case of a non-constant >>> inbetween? >> >> Only if there is no overlap at all, otherwise you cannot do things simply. >> >>> Can you have a look / review here?

Re: [PATCH] PR86844: Fix for store merging

2018-08-20 Thread Jeff Law
On 08/18/2018 03:20 AM, Eric Botcazou wrote: >> Eric, didn't your patches explicitely handle this case of a non-constant >> inbetween? > > Only if there is no overlap at all, otherwise you cannot do things simply. > >> Can you have a look / review here? > > Jakub is probably more qualified to gi

Re: [PATCH] PR86844: Fix for store merging

2018-08-18 Thread Eric Botcazou
> Eric, didn't your patches explicitely handle this case of a non-constant > inbetween? Only if there is no overlap at all, otherwise you cannot do things simply. > Can you have a look / review here? Jakub is probably more qualified to give a definitive opinion, as he wrote check_no_overlap and

Re: [PATCH] PR86844: Fix for store merging

2018-08-17 Thread Richard Biener
On Tue, Aug 7, 2018 at 1:35 PM Andreas Krebbel wrote: > > From: Andreas Krebbel > > Bootstrapped and regtested on s390x and x86_64. Eric, didn't your patches explicitely handle this case of a non-constant inbetween? Can you have a look / review here? Thanks, Richard. > gcc/ChangeLog: > > 2018

[PATCH] PR86844: Fix for store merging

2018-08-07 Thread Andreas Krebbel
From: Andreas Krebbel Bootstrapped and regtested on s390x and x86_64. gcc/ChangeLog: 2018-08-07 Andreas Krebbel PR tree-optimization/86844 * gimple-ssa-store-merging.c (check_no_overlap): Add a check to reject overlaps if it has seen a non-constant store in between.