Re: [PATCH] PR70674: S/390: Add memory barrier to stack pointer restore from fpr.

2016-04-19 Thread Andreas Krebbel
On 04/19/2016 12:54 PM, Jakub Jelinek wrote: > Can you please: > rtx fpr = gen_rtx_REG (DImode, cfun_gpr_save_slot (i)); > if (i == STACK_POINTER_REGNUM) > insn = emit_insn (gen_stack_restore_from_fpr (fpr)); > else > insn = emit_move_insn (gen_rtx_REG (DImode, i),

Re: [PATCH] PR70674: S/390: Add memory barrier to stack pointer restore from fpr.

2016-04-19 Thread Jakub Jelinek
On Tue, Apr 19, 2016 at 11:02:34AM +0200, Andreas Krebbel wrote: > I'll post the patches for the other two parts when gcc 7 entered stage > 1 again. It will not reenter stage 1 again, that happened last Friday ;) > This needs to go into 4.9/5/6 branches. Ok for 6, but I have formatting nit: > +

[PATCH] PR70674: S/390: Add memory barrier to stack pointer restore from fpr.

2016-04-19 Thread Andreas Krebbel
This patches fixes a problem with stack variable accesses being scheduled after the stack pointer restore instructions. In the testcase this happened with the stack variable 'a' accessed through the frame pointer. The existing stack_tie we have in the backend is basically useless when trying to b