Re: [PATCH] PR70117, ppc long double isinf

2016-04-07 Thread Richard Biener
On April 8, 2016 5:03:04 AM GMT+02:00, Alan Modra wrote: >On Thu, Apr 07, 2016 at 10:43:31AM -0400, David Edelsohn wrote: >> Yes, I have been following this entertaining thread. > >How to waste lots of time over one bit. Floating point is like that. >:-) > >I see the bug was opened against 5.3, s

Re: [PATCH] PR70117, ppc long double isinf

2016-04-07 Thread Alan Modra
On Thu, Apr 07, 2016 at 10:43:31AM -0400, David Edelsohn wrote: > Yes, I have been following this entertaining thread. How to waste lots of time over one bit. Floating point is like that. :-) I see the bug was opened against 5.3, so OK to commit there after a few days and maybe 4.9 too, Richard?

Re: [PATCH] PR70117, ppc long double isinf

2016-04-07 Thread David Edelsohn
On Thu, Apr 7, 2016 at 10:17 AM, Alan Modra wrote: > On Thu, Apr 07, 2016 at 11:32:58AM +0200, Richard Biener wrote: >> That's good to know. I think the patch is OK but please seek approval from >> a ppc maintainer as well > > There's only one of those. David? Thread starts here > https://gcc.

Re: [PATCH] PR70117, ppc long double isinf

2016-04-07 Thread Alan Modra
On Thu, Apr 07, 2016 at 11:32:58AM +0200, Richard Biener wrote: > That's good to know. I think the patch is OK but please seek approval from a > ppc maintainer as well There's only one of those. David? Thread starts here https://gcc.gnu.org/ml/gcc-patches/2016-04/msg00213.html -- Alan Modra

Re: [PATCH] PR70117, ppc long double isinf

2016-04-07 Thread Richard Biener
On April 7, 2016 10:03:54 AM GMT+02:00, Alan Modra wrote: >On Wed, Apr 06, 2016 at 06:49:19PM +0930, Alan Modra wrote: >> On Wed, Apr 06, 2016 at 10:46:48AM +0200, Richard Biener wrote: >> > Can you add a testcase or two for the isnormal () case? >> >> Sure. I'll adapt the testcase I was using t

Re: [PATCH] PR70117, ppc long double isinf

2016-04-07 Thread Alan Modra
On Wed, Apr 06, 2016 at 06:49:19PM +0930, Alan Modra wrote: > On Wed, Apr 06, 2016 at 10:46:48AM +0200, Richard Biener wrote: > > Can you add a testcase or two for the isnormal () case? > > Sure. I'll adapt the testcase I was using to verify the output, Revised testcase - target fixed, compiled

Re: [PATCH] PR70117, ppc long double isinf

2016-04-06 Thread Alan Modra
On Wed, Apr 06, 2016 at 12:27:36PM +0200, Andreas Schwab wrote: > Alan Modra writes: > > > diff --git a/gcc/testsuite/gcc.target/powerpc/pr70117.c > > b/gcc/testsuite/gcc.target/powerpc/pr70117.c > > new file mode 100644 > > index 000..99e6f19 > > --- /dev/null > > +++ b/gcc/testsuite/gcc.ta

Re: [PATCH] PR70117, ppc long double isinf

2016-04-06 Thread Andreas Schwab
Alan Modra writes: > diff --git a/gcc/testsuite/gcc.target/powerpc/pr70117.c > b/gcc/testsuite/gcc.target/powerpc/pr70117.c > new file mode 100644 > index 000..99e6f19 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/pr70117.c > @@ -0,0 +1,22 @@ > +/* { dg-do run { target { { powerpc

Re: [PATCH] PR70117, ppc long double isinf

2016-04-06 Thread Alan Modra
On Wed, Apr 06, 2016 at 10:46:48AM +0200, Richard Biener wrote: > On Wed, Apr 6, 2016 at 10:31 AM, Alan Modra wrote: > > On Tue, Apr 05, 2016 at 11:29:30AM +0200, Richard Biener wrote: > >> In general the patch looks like a good approach to me but can we > >> hide that > >> > >> > + const struct

Re: [PATCH] PR70117, ppc long double isinf

2016-04-06 Thread Richard Biener
On Wed, Apr 6, 2016 at 10:31 AM, Alan Modra wrote: > On Tue, Apr 05, 2016 at 11:29:30AM +0200, Richard Biener wrote: >> In general the patch looks like a good approach to me but can we >> hide that >> >> > + const struct real_format *fmt = FLOAT_MODE_FORMAT (mode); >> > + bool is_ibm_extended =

[PATCH] PR70117, ppc long double isinf

2016-04-06 Thread Alan Modra
On Tue, Apr 05, 2016 at 11:29:30AM +0200, Richard Biener wrote: > In general the patch looks like a good approach to me but can we > hide that > > > + const struct real_format *fmt = FLOAT_MODE_FORMAT (mode); > > + bool is_ibm_extended = fmt->pnan < fmt->p; > > in a function somewhere in real.[