Re: [PATCH] PR64959: SFINAE in UDLs

2015-02-19 Thread Jakub Jelinek
On Fri, Feb 13, 2015 at 11:21:26PM +0100, Andrea Azzarone wrote: > We can use the same trick used in the other tests. Patch attached. > Sorry about that! Thanks. I wrote a ChangeLog entry for this and committed. Jakub

Re: [PATCH] PR64959: SFINAE in UDLs

2015-02-19 Thread Alex Velenko
On 18/02/15 18:30, Jakub Jelinek wrote: On Wed, Feb 18, 2015 at 06:29:34PM +, Alex Velenko wrote: this patch also fixes issues for arm-none-eabi. Could someone add this patch? ENOPATCH Jakub Hi Jakub, I meant Andrea Azzarone's patch in the previous e-mail. It has not been added

Re: [PATCH] PR64959: SFINAE in UDLs

2015-02-18 Thread Alex Velenko
On 13/02/15 22:21, Andrea Azzarone wrote: We can use the same trick used in the other tests. Patch attached. Sorry about that! 2015-02-13 20:45 GMT+01:00 Jakub Jelinek : On Wed, Feb 11, 2015 at 12:26:33AM +0100, Andrea Azzarone wrote: * gcc/testsuite/g++.dg/cpp1y/udlit-char-template-vs-

Re: [PATCH] PR64959: SFINAE in UDLs

2015-02-18 Thread Jakub Jelinek
On Wed, Feb 18, 2015 at 06:29:34PM +, Alex Velenko wrote: > this patch also fixes issues for arm-none-eabi. > Could someone add this patch? ENOPATCH Jakub

Re: [PATCH] PR64959: SFINAE in UDLs

2015-02-13 Thread Andrea Azzarone
We can use the same trick used in the other tests. Patch attached. Sorry about that! 2015-02-13 20:45 GMT+01:00 Jakub Jelinek : > On Wed, Feb 11, 2015 at 12:26:33AM +0100, Andrea Azzarone wrote: >> * >> gcc/testsuite/g++.dg/cpp1y/udlit-char-template-vs-std-literal-operator.C: > > This fails o

Re: [PATCH] PR64959: SFINAE in UDLs

2015-02-13 Thread Jakub Jelinek
On Wed, Feb 11, 2015 at 12:26:33AM +0100, Andrea Azzarone wrote: > * > gcc/testsuite/g++.dg/cpp1y/udlit-char-template-vs-std-literal-operator.C: This fails on i686-linux: FAIL: g++.dg/cpp1y/udlit-char-template-vs-std-literal-operator.C -std=c++14 (test for excess errors) Excess errors: /h

Re: [PATCH] PR64959: SFINAE in UDLs

2015-02-12 Thread Jason Merrill
Applied, thanks. I wrapped some lines that were over 80 characters long. Jason

Re: [PATCH] PR64959: SFINAE in UDLs

2015-02-10 Thread Andrea Azzarone
Hi, Thanks for the review. I updated the patch. 2015-2-9 Andrea Azzarone PR c++/64959 * parser.c (lookup_literal_operator): Return all candidates. (cp_parser_userdef_char_literal): Simplify error handling. (cp_parser_userdef_numeric_literal): Pass tf_warning_or_error.

Re: [PATCH] PR64959: SFINAE in UDLs

2015-02-10 Thread Jason Merrill
On 02/09/2015 08:27 AM, Andrea Azzarone wrote: Please note that this is my first gcc patch Thanks, looks good! A couple of nits: * gcc/cp/parser.c: Make sure lookup_literal_operator returns all the possible candidates. Also improve the diagnostic messages. A ChangeLog entry should be p

[PATCH] PR64959: SFINAE in UDLs

2015-02-09 Thread Andrea Azzarone
Hi all, atm enable_if cannot be used to select between overload of UDLs. E.g. https://gcc.gnu.org/bugzilla/attachment.cgi?id=34684 will not compile. This can be easily fixed making sure that lookup_literal_operator returns all the possible candidates and not just the first match. I made some more