Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-27 Thread Eric Botcazou
> do you have any other (system) version of GCC, configured without > --disable-libsanitizer? Nope. > 2) Make check_effective_target_fsanitize_address not only link dummy > executable, but also run it and verify that exit code equals zero. Yes, probably something along these lines, or restore th

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-24 Thread Maxim Ostapenko
On 10/24/2014 02:43 PM, Eric Botcazou wrote: some time ago, Andrew wrote a patch that fixes PR58867 (http://patchwork.ozlabs.org/patch/286866/), but for some reasons it wasn't committed to trunk. This is resurrected Andrew's patch, extended to support Tsan testsuite. This patch broke --disable

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-24 Thread Eric Botcazou
> some time ago, Andrew wrote a patch that fixes PR58867 > (http://patchwork.ozlabs.org/patch/286866/), but for some reasons it > wasn't committed to trunk. > > This is resurrected Andrew's patch, extended to support Tsan testsuite. This patch broke --disable-libsanitizer though, i.e. you now get

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-08 Thread Jiong Wang
On 08/10/14 17:19, Maxim Ostapenko wrote: Hi Jiong, I couldn't reproduce tests failures on my box, perhaps I missed something. How can I test this? Hi Maxim, What I mean is after this patch, those fails gone away on my test environment also. I am just not sure whether the remove will c

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-08 Thread Maxim Ostapenko
Hi Jiong, I couldn't reproduce tests failures on my box, perhaps I missed something. How can I test this? -Maxim On 10/08/2014 06:30 PM, Jiong Wang wrote: On 08/10/14 15:00, Maxim Ostapenko wrote: Hm, as I see, others testsuites such as gfortran.exp, go.exp etc. do not call restore_ld_libra

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-08 Thread Jiong Wang
On 08/10/14 15:00, Maxim Ostapenko wrote: Hm, as I see, others testsuites such as gfortran.exp, go.exp etc. do not call restore_ld_library_path at all. Perhaps we could simply follow this way? Would failing tests still fail if remove restore_ld_library_path from {asan, tsan, ubsan}_finish? Hi

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-08 Thread Maxim Ostapenko
Hm, as I see, others testsuites such as gfortran.exp, go.exp etc. do not call restore_ld_library_path at all. Perhaps we could simply follow this way? Would failing tests still fail if remove restore_ld_library_path from {asan, tsan, ubsan}_finish? On 10/08/2014 03:40 PM, Marcus Shawcroft wr

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-08 Thread Marcus Shawcroft
On 8 October 2014 11:10, Maxim Ostapenko wrote: > Does it work without restore_ld_library_path in {asan, ubsan, tsan}_finish? > > I see two opportunities to fix the issue: > > 1) Implement a stack of saved contexts. > > 2) Implement new functions, say {asan, ubsan, tsan}_restore_ld_library_path, >

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-08 Thread Maxim Ostapenko
Does it work without restore_ld_library_path in {asan, ubsan, tsan}_finish? I see two opportunities to fix the issue: 1) Implement a stack of saved contexts. 2) Implement new functions, say {asan, ubsan, tsan}_restore_ld_library_path, to be able {asan, ubsan, tsan}_finish functions restore co

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-08 Thread Marcus Shawcroft
On 1 October 2014 08:09, Maxim Ostapenko wrote: > Hi, > > some time ago, Andrew wrote a patch that fixes PR58867 > (http://patchwork.ozlabs.org/patch/286866/), but for some reasons it > wasn't committed to trunk. > > This is resurrected Andrew's patch, extended to support Tsan testsuite. > > Teste

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-01 Thread Jakub Jelinek
On Wed, Oct 01, 2014 at 05:31:46AM -0700, Mike Stump wrote: > > > On 10/01/2014 11:09 AM, Maxim Ostapenko wrote: > >> Hi, > >> > >> some time ago, Andrew wrote a patch that fixes PR58867 > >> (http://patchwork.ozlabs.org/patch/286866/), but for some reasons it > >> wasn't committed to trunk. > >

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-01 Thread Mike Stump
> On 10/01/2014 11:09 AM, Maxim Ostapenko wrote: >> Hi, >> >> some time ago, Andrew wrote a patch that fixes PR58867 >> (http://patchwork.ozlabs.org/patch/286866/), but for some reasons it >> wasn't committed to trunk. >> >> This is resurrected Andrew's patch, extended to support Tsan testsuite

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-01 Thread Maxim Ostapenko
Adding Joseph S. Myers as bug reporter. On 10/01/2014 11:09 AM, Maxim Ostapenko wrote: Hi, some time ago, Andrew wrote a patch that fixes PR58867 (http://patchwork.ozlabs.org/patch/286866/), but for some reasons it wasn't committed to trunk. This is resurrected Andrew's patch, extended to su

[PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-01 Thread Maxim Ostapenko
Hi, some time ago, Andrew wrote a patch that fixes PR58867 (http://patchwork.ozlabs.org/patch/286866/), but for some reasons it wasn't committed to trunk. This is resurrected Andrew's patch, extended to support Tsan testsuite. Tested on x86_64-pc-linux-gnu, ok to commit? -Maxim ChangeLog: 2