PING^3: [PATCH] PR33661 Fix problem with register asm in templates

2016-06-20 Thread Andreas Krebbel
Hi Jason, could you please have a look? https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00904.html Thanks! -Andreas-

PING: [PATCH] PR33661 Fix problem with register asm in templates

2016-06-07 Thread Andreas Krebbel
Hi Jason, could you please have a look? https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00904.html Thanks! -Andreas-

PING: [PATCH] PR33661 Fix problem with register asm in templates

2016-04-25 Thread Andreas Krebbel
Hi Jason, I recently did run into this again. Could you please have a look? https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00904.html Thanks! -Andreas-

Re: [PATCH] PR33661 Fix problem with register asm in templates

2015-06-12 Thread Andreas Krebbel
On 06/12/2015 11:24 AM, Jakub Jelinek wrote: > Looks mostly good, just wonder about the powerpc scan-assembler. > Shouldn't that be "reg: (%r)?8" instead? I think powerpc has -mregnames > option, dunno if some target doesn't even use it by default. Good catch. I'll change that. -Andreas-

Re: [PATCH] PR33661 Fix problem with register asm in templates

2015-06-12 Thread Jakub Jelinek
On Fri, Jun 12, 2015 at 10:52:56AM +0200, Andreas Krebbel wrote: > Yes that's better. I've adjusted the testcase as you proposed and > have tested it on x86_64, ppc, and s390x with -m32(-m31) and -m64. As I said earlier, talking just about the testcase, leaving review to Jason. > --- /dev/null >

Re: [PATCH] PR33661 Fix problem with register asm in templates

2015-06-12 Thread Andreas Krebbel
Yes that's better. I've adjusted the testcase as you proposed and have tested it on x86_64, ppc, and s390x with -m32(-m31) and -m64. Bye, -Andreas- gcc/cp/ 2015-06-12 Andreas Krebbel PR c++/33661 * decl.c (cp_finish_decl): Set assembler name for register asm constru

Re: [PATCH] PR33661 Fix problem with register asm in templates

2015-06-11 Thread Jakub Jelinek
Hi! Just nits, I'll defer the review to a C++ maintainer. On Thu, Jun 11, 2015 at 03:49:48PM +0200, Andreas Krebbel wrote: > 2015-06-11 Andreas Krebbel > > PR C++/33661 > * gcc/cp/decl.c (cp_finish_decl): Set assembler name for register > asm constructs. > * gcc/cp/pt

[PATCH] PR33661 Fix problem with register asm in templates

2015-06-11 Thread Andreas Krebbel
Hi, register asm declarations currently don't work when being expanded as part of a function template. There appeared to be two problems: 1. When parsing a template function cp_finish_decl returns before the asmspec is set in the var decl. 2. When expanding the template function the assembler_na