Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-05 Thread Richard Sandiford
Mike Stump writes: > On Aug 4, 2013, at 8:14 AM, Chung-Lin Tang wrote: >> On 13/7/15 1:43 AM, Diego Novillo wrote: >>> Could you please repost the patch with its description? This thread >>> is sufficiently old and noisy that I'm not even sure what the patch >>> does nor why. >> >> Taking the s

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-05 Thread Chung-Lin Tang
On 13/8/5 下午10:24, Mike Stump wrote: > On Aug 5, 2013, at 7:15 AM, Chung-Lin Tang wrote: >> On 13/8/5 10:06 PM, Mike Stump wrote: >>> On Aug 4, 2013, at 8:14 AM, Chung-Lin Tang wrote: On 13/7/15 1:43 AM, Diego Novillo wrote: > Could you please repost the patch with its description? This

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-05 Thread Mike Stump
On Aug 5, 2013, at 7:15 AM, Chung-Lin Tang wrote: > On 13/8/5 10:06 PM, Mike Stump wrote: >> On Aug 4, 2013, at 8:14 AM, Chung-Lin Tang wrote: >>> On 13/7/15 1:43 AM, Diego Novillo wrote: Could you please repost the patch with its description? This thread is sufficiently old and noisy

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-05 Thread Chung-Lin Tang
On 13/8/5 10:06 PM, Mike Stump wrote: > On Aug 4, 2013, at 8:14 AM, Chung-Lin Tang wrote: >> On 13/7/15 1:43 AM, Diego Novillo wrote: >>> Could you please repost the patch with its description? This thread >>> is sufficiently old and noisy that I'm not even sure what the patch >>> does nor why. >

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-05 Thread Mike Stump
[ sorry for the dup ] On Aug 4, 2013, at 8:14 AM, Chung-Lin Tang wrote: > On 13/7/15 1:43 AM, Diego Novillo wrote: >> Could you please repost the patch with its description? This thread >> is sufficiently old and noisy that I'm not even sure what the patch >> does nor why. > > Taking the same

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-05 Thread Mike Stump
On Aug 4, 2013, at 8:14 AM, Chung-Lin Tang wrote: > On 13/7/15 1:43 AM, Diego Novillo wrote: >> Could you please repost the patch with its description? This thread >> is sufficiently old and noisy that I'm not even sure what the patch >> does nor why. > > Taking the same example in my first post

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-04 Thread Bernhard Reutner-Fischer
On 4 August 2013 17:14:36 Chung-Lin Tang wrote: On 13/7/15 1:43 AM, Diego Novillo wrote: > Could you please repost the patch with its description? This thread > is sufficiently old and noisy that I'm not even sure what the patch > does nor why. Taking the same example in my first post: extern

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-04 Thread Chung-Lin Tang
On 13/7/15 1:43 AM, Diego Novillo wrote: > Could you please repost the patch with its description? This thread > is sufficiently old and noisy that I'm not even sure what the patch > does nor why. Taking the same example in my first post: extern void weakfun() __attribute__((weak,visibility("hid

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-01 Thread Chung-Lin Tang
On 13/8/1 5:16 PM, Bernhard Reutner-Fischer wrote: > On 14 July 2013 19:43, Diego Novillo wrote: >> On Sun, Jul 14, 2013 at 2:08 AM, Chung-Lin Tang >> wrote: >>> Ping. >> >> Could you please repost the patch with its description? This thread >> is sufficiently old and noisy that I'm not even su

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-01 Thread Bernhard Reutner-Fischer
On 14 July 2013 19:43, Diego Novillo wrote: > On Sun, Jul 14, 2013 at 2:08 AM, Chung-Lin Tang > wrote: >> Ping. > > Could you please repost the patch with its description? This thread > is sufficiently old and noisy that I'm not even sure what the patch > does nor why. Chung-Lin Tang, can you

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-07-14 Thread Diego Novillo
On Sun, Jul 14, 2013 at 2:08 AM, Chung-Lin Tang wrote: > Ping. Could you please repost the patch with its description? This thread is sufficiently old and noisy that I'm not even sure what the patch does nor why. Thanks. Diego.

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-07-14 Thread Chung-Lin Tang
Ping. On 2013/6/20 03:01 PM, Chung-Lin Tang wrote: > Ping again? > > On 13/6/11 5:20 PM, Bernhard Reutner-Fischer wrote: >> ping, CCing middle-end maintainers for review. >> >> On 31 May 2013 10:13, Chung-Lin Tang wrote: >>> On 13/5/15 8:12 PM, Richard Sandiford wrote: Chung-Lin Tang write

Re: [PATCH] PR32219, weak hidden reference segfault [PING]

2013-06-20 Thread Chung-Lin Tang
Ping again? On 13/6/11 5:20 PM, Bernhard Reutner-Fischer wrote: > ping, CCing middle-end maintainers for review. > > On 31 May 2013 10:13, Chung-Lin Tang wrote: >> On 13/5/15 8:12 PM, Richard Sandiford wrote: >>> Chung-Lin Tang writes: On 13/5/10 6:37 PM, Richard Sandiford wrote: > Chu

Re: [PATCH] PR32219, weak hidden reference segfault

2013-06-11 Thread Bernhard Reutner-Fischer
ping, CCing middle-end maintainers for review. On 31 May 2013 10:13, Chung-Lin Tang wrote: > On 13/5/15 8:12 PM, Richard Sandiford wrote: >> Chung-Lin Tang writes: >>> On 13/5/10 6:37 PM, Richard Sandiford wrote: Chung-Lin Tang writes: > +case UNSPEC: > + /* Reach for a co

Re: [PATCH] PR32219, weak hidden reference segfault

2013-05-31 Thread Chung-Lin Tang
On 13/5/15 8:12 PM, Richard Sandiford wrote: > Chung-Lin Tang writes: >> On 13/5/10 6:37 PM, Richard Sandiford wrote: >>> Chung-Lin Tang writes: +case UNSPEC: + /* Reach for a contained symbol. */ + return nonzero_address_p (XVECEXP (x, 0, 0)); >>> >>> I don't think

Re: [PATCH] PR32219, weak hidden reference segfault

2013-05-15 Thread Richard Sandiford
Chung-Lin Tang writes: > On 13/5/10 6:37 PM, Richard Sandiford wrote: >> Chung-Lin Tang writes: >>> +case UNSPEC: >>> + /* Reach for a contained symbol. */ >>> + return nonzero_address_p (XVECEXP (x, 0, 0)); >> >> I don't think this is safe. UNSPECs really are unspecified :-), >>

Re: [PATCH] PR32219, weak hidden reference segfault

2013-05-15 Thread Chung-Lin Tang
On 13/5/10 6:37 PM, Richard Sandiford wrote: > Chung-Lin Tang writes: >> +case UNSPEC: >> + /* Reach for a contained symbol. */ >> + return nonzero_address_p (XVECEXP (x, 0, 0)); > > I don't think this is safe. UNSPECs really are unspecified :-), > so we can't assume that (unspec

Re: [PATCH] PR32219, weak hidden reference segfault

2013-05-10 Thread Richard Sandiford
Chung-Lin Tang writes: > +case UNSPEC: > + /* Reach for a contained symbol. */ > + return nonzero_address_p (XVECEXP (x, 0, 0)); I don't think this is safe. UNSPECs really are unspecified :-), so we can't assume that (unspec X) is nonzero simply because X is. Richard

Re: [PATCH] PR32219, weak hidden reference segfault

2013-05-09 Thread Bernhard Reutner-Fischer
On Thu, May 09, 2013 at 05:52:26PM +0800, Chung-Lin Tang wrote: >2013-05-09 Chung-Lin Tang > > PR target/32219 > * rtlanal.c (nonzero_address_p): Robustify checking by look >recursively into PIC constant offsets and (CONST (UNSPEC ...)) > expressions. >Index: rtlanal.

[PATCH] PR32219, weak hidden reference segfault

2013-05-09 Thread Chung-Lin Tang
Hi, with reference to the old dicussion on PR 32219: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32219 It seems that a patch was submitted to put the DECL_WEAK check before the visibility check, but that patch was never approved or applied, due to concerns in the wording of surrounding comments: h