Re: [PATCH] PR target/81313: Use DRAP only if there are outgoing arguments on stack

2017-07-09 Thread H.J. Lu
On Sun, Jul 9, 2017 at 11:57 AM, Uros Bizjak wrote: > On Sun, Jul 9, 2017 at 8:29 PM, H.J. Lu wrote: >> On Sun, Jul 9, 2017 at 11:19 AM, Uros Bizjak wrote: >>> On Fri, Jul 7, 2017 at 12:14 AM, H.J. Lu wrote: On Thu, Jul 6, 2017 at 12:08 PM, H.J. Lu wrote: > Since DRAP is needed only i

Re: [PATCH] PR target/81313: Use DRAP only if there are outgoing arguments on stack

2017-07-09 Thread Uros Bizjak
On Sun, Jul 9, 2017 at 9:06 PM, H.J. Lu wrote: >>> PR target/81313 >>> * gcc.dg/stack-layout-dynamic-1.c (dg-options): Add -mregparm=3 >>> for ia32. >>> Don't expect cfi_escape and expect cfi_def_cfa_register on x86. >>> >>> OK for trunk? >> >> Better use something like: >> >> --cut here-- >> Ind

Re: [PATCH] PR target/81313: Use DRAP only if there are outgoing arguments on stack

2017-07-09 Thread H.J. Lu
On Sun, Jul 9, 2017 at 11:57 AM, Uros Bizjak wrote: > On Sun, Jul 9, 2017 at 8:29 PM, H.J. Lu wrote: >> On Sun, Jul 9, 2017 at 11:19 AM, Uros Bizjak wrote: >>> On Fri, Jul 7, 2017 at 12:14 AM, H.J. Lu wrote: On Thu, Jul 6, 2017 at 12:08 PM, H.J. Lu wrote: > Since DRAP is needed only i

Re: [PATCH] PR target/81313: Use DRAP only if there are outgoing arguments on stack

2017-07-09 Thread Uros Bizjak
On Sun, Jul 9, 2017 at 8:29 PM, H.J. Lu wrote: > On Sun, Jul 9, 2017 at 11:19 AM, Uros Bizjak wrote: >> On Fri, Jul 7, 2017 at 12:14 AM, H.J. Lu wrote: >>> On Thu, Jul 6, 2017 at 12:08 PM, H.J. Lu wrote: Since DRAP is needed only if there are outgoing arguments on stack, we should tra

Re: [PATCH] PR target/81313: Use DRAP only if there are outgoing arguments on stack

2017-07-09 Thread H.J. Lu
On Sun, Jul 9, 2017 at 11:19 AM, Uros Bizjak wrote: > On Fri, Jul 7, 2017 at 12:14 AM, H.J. Lu wrote: >> On Thu, Jul 6, 2017 at 12:08 PM, H.J. Lu wrote: >>> Since DRAP is needed only if there are outgoing arguments on stack, we >>> should track outgoing arguments on stack and avoid setting need_

Re: [PATCH] PR target/81313: Use DRAP only if there are outgoing arguments on stack

2017-07-09 Thread Uros Bizjak
On Fri, Jul 7, 2017 at 12:14 AM, H.J. Lu wrote: > On Thu, Jul 6, 2017 at 12:08 PM, H.J. Lu wrote: >> Since DRAP is needed only if there are outgoing arguments on stack, we >> should track outgoing arguments on stack and avoid setting need_drap to >> true when there are no outgoing arguments on st

Re: [PATCH] PR target/81313: Use DRAP only if there are outgoing arguments on stack

2017-07-06 Thread H.J. Lu
On Thu, Jul 6, 2017 at 12:08 PM, H.J. Lu wrote: > Since DRAP is needed only if there are outgoing arguments on stack, we > should track outgoing arguments on stack and avoid setting need_drap to > true when there are no outgoing arguments on stack. > > Tested on i686 and x86-64 with SSE2, AVX and

[PATCH] PR target/81313: Use DRAP only if there are outgoing arguments on stack

2017-07-06 Thread H.J. Lu
Since DRAP is needed only if there are outgoing arguments on stack, we should track outgoing arguments on stack and avoid setting need_drap to true when there are no outgoing arguments on stack. Tested on i686 and x86-64 with SSE2, AVX and AVX2. There is no regression. OK for trunk? H.J. --- gc