Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-27 Thread H.J. Lu
On Wed, Apr 27, 2016 at 6:28 AM, Uros Bizjak wrote: > On Wed, Apr 27, 2016 at 2:51 PM, H.J. Lu wrote: >> On Wed, Apr 27, 2016 at 5:03 AM, Uros Bizjak wrote: >>> On Tue, Apr 26, 2016 at 9:50 PM, H.J. Lu wrote: >>> > Here is the updated patch which does that. Ok for trunk if there > is n

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-27 Thread Uros Bizjak
On Wed, Apr 27, 2016 at 2:51 PM, H.J. Lu wrote: > On Wed, Apr 27, 2016 at 5:03 AM, Uros Bizjak wrote: >> On Tue, Apr 26, 2016 at 9:50 PM, H.J. Lu wrote: >> Here is the updated patch which does that. Ok for trunk if there is no regressions on x86-64? >>> >>> CSE works with SSE con

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-27 Thread H.J. Lu
On Wed, Apr 27, 2016 at 5:03 AM, Uros Bizjak wrote: > On Tue, Apr 26, 2016 at 9:50 PM, H.J. Lu wrote: > >>> Here is the updated patch which does that. Ok for trunk if there >>> is no regressions on x86-64? >>> >> >> CSE works with SSE constants now. Here is the updated patch. >> OK for trunk if

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-27 Thread Uros Bizjak
On Tue, Apr 26, 2016 at 9:50 PM, H.J. Lu wrote: >> Here is the updated patch which does that. Ok for trunk if there >> is no regressions on x86-64? >> > > CSE works with SSE constants now. Here is the updated patch. > OK for trunk if there are no regressions on x86-64? +static bool +timode_sca

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-27 Thread Ilya Enkovich
2016-04-26 22:50 GMT+03:00 H.J. Lu : > On Tue, Apr 26, 2016 at 11:42 AM, H.J. Lu wrote: >> On Tue, Apr 26, 2016 at 9:33 AM, H.J. Lu wrote: >>> On Tue, Apr 26, 2016 at 9:27 AM, Ilya Enkovich >>> wrote: 2016-04-26 19:20 GMT+03:00 Ilya Enkovich : > 2016-04-26 19:12 GMT+03:00 H.J. Lu : >>>

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread H.J. Lu
On Tue, Apr 26, 2016 at 11:42 AM, H.J. Lu wrote: > On Tue, Apr 26, 2016 at 9:33 AM, H.J. Lu wrote: >> On Tue, Apr 26, 2016 at 9:27 AM, Ilya Enkovich >> wrote: >>> 2016-04-26 19:20 GMT+03:00 Ilya Enkovich : 2016-04-26 19:12 GMT+03:00 H.J. Lu : > On Tue, Apr 26, 2016 at 9:07 AM, Ilya Enk

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread H.J. Lu
On Tue, Apr 26, 2016 at 9:33 AM, H.J. Lu wrote: > On Tue, Apr 26, 2016 at 9:27 AM, Ilya Enkovich wrote: >> 2016-04-26 19:20 GMT+03:00 Ilya Enkovich : >>> 2016-04-26 19:12 GMT+03:00 H.J. Lu : On Tue, Apr 26, 2016 at 9:07 AM, Ilya Enkovich wrote: > 2016-04-26 18:39 GMT+03:00 H.J. Lu

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread H.J. Lu
On Tue, Apr 26, 2016 at 9:27 AM, Ilya Enkovich wrote: > 2016-04-26 19:20 GMT+03:00 Ilya Enkovich : >> 2016-04-26 19:12 GMT+03:00 H.J. Lu : >>> On Tue, Apr 26, 2016 at 9:07 AM, Ilya Enkovich >>> wrote: 2016-04-26 18:39 GMT+03:00 H.J. Lu : > On Tue, Apr 26, 2016 at 8:21 AM, Ilya Enkovich

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread H.J. Lu
On Tue, Apr 26, 2016 at 9:20 AM, Ilya Enkovich wrote: > 2016-04-26 19:12 GMT+03:00 H.J. Lu : >> On Tue, Apr 26, 2016 at 9:07 AM, Ilya Enkovich >> wrote: >>> 2016-04-26 18:39 GMT+03:00 H.J. Lu : On Tue, Apr 26, 2016 at 8:21 AM, Ilya Enkovich wrote: > 2016-04-26 18:12 GMT+03:00 H.J

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread Ilya Enkovich
2016-04-26 19:20 GMT+03:00 Ilya Enkovich : > 2016-04-26 19:12 GMT+03:00 H.J. Lu : >> On Tue, Apr 26, 2016 at 9:07 AM, Ilya Enkovich >> wrote: >>> 2016-04-26 18:39 GMT+03:00 H.J. Lu : On Tue, Apr 26, 2016 at 8:21 AM, Ilya Enkovich wrote: > 2016-04-26 18:12 GMT+03:00 H.J. Lu : >

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread Ilya Enkovich
2016-04-26 19:12 GMT+03:00 H.J. Lu : > On Tue, Apr 26, 2016 at 9:07 AM, Ilya Enkovich wrote: >> 2016-04-26 18:39 GMT+03:00 H.J. Lu : >>> On Tue, Apr 26, 2016 at 8:21 AM, Ilya Enkovich >>> wrote: 2016-04-26 18:12 GMT+03:00 H.J. Lu : > On Tue, Apr 26, 2016 at 8:05 AM, Ilya Enkovich

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread H.J. Lu
On Tue, Apr 26, 2016 at 9:07 AM, Ilya Enkovich wrote: > 2016-04-26 18:39 GMT+03:00 H.J. Lu : >> On Tue, Apr 26, 2016 at 8:21 AM, Ilya Enkovich >> wrote: >>> 2016-04-26 18:12 GMT+03:00 H.J. Lu : On Tue, Apr 26, 2016 at 8:05 AM, Ilya Enkovich wrote: > 2016-04-26 17:55 GMT+03:00 H.J

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread Ilya Enkovich
2016-04-26 18:39 GMT+03:00 H.J. Lu : > On Tue, Apr 26, 2016 at 8:21 AM, Ilya Enkovich wrote: >> 2016-04-26 18:12 GMT+03:00 H.J. Lu : >>> On Tue, Apr 26, 2016 at 8:05 AM, Ilya Enkovich >>> wrote: 2016-04-26 17:55 GMT+03:00 H.J. Lu : > On Tue, Apr 26, 2016 at 7:15 AM, Ilya Enkovich

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread H.J. Lu
On Tue, Apr 26, 2016 at 8:21 AM, Ilya Enkovich wrote: > 2016-04-26 18:12 GMT+03:00 H.J. Lu : >> On Tue, Apr 26, 2016 at 8:05 AM, Ilya Enkovich >> wrote: >>> 2016-04-26 17:55 GMT+03:00 H.J. Lu : On Tue, Apr 26, 2016 at 7:15 AM, Ilya Enkovich wrote: > 2016-04-26 17:07 GMT+03:00 H.J

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread H.J. Lu
On Tue, Apr 26, 2016 at 2:35 AM, Richard Biener wrote: > On Tue, 26 Apr 2016, Uros Bizjak wrote: > >> On Tue, Apr 26, 2016 at 11:17 AM, Richard Biener wrote: >> > On Mon, 25 Apr 2016, Uros Bizjak wrote: >> > >> >> On Mon, Apr 25, 2016 at 4:47 PM, H.J. Lu wrote: >> >> > On Mon, Apr 25, 2016 at 7:

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread Ilya Enkovich
2016-04-26 18:12 GMT+03:00 H.J. Lu : > On Tue, Apr 26, 2016 at 8:05 AM, Ilya Enkovich wrote: >> 2016-04-26 17:55 GMT+03:00 H.J. Lu : >>> On Tue, Apr 26, 2016 at 7:15 AM, Ilya Enkovich >>> wrote: 2016-04-26 17:07 GMT+03:00 H.J. Lu : > On Mon, Apr 25, 2016 at 9:13 AM, Ilya Enkovich

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread Jeff Law
On 04/26/2016 03:17 AM, Richard Biener wrote: On Mon, 25 Apr 2016, Uros Bizjak wrote: On Mon, Apr 25, 2016 at 4:47 PM, H.J. Lu wrote: On Mon, Apr 25, 2016 at 7:18 AM, Uros Bizjak wrote: On Mon, Apr 25, 2016 at 2:51 PM, H.J. Lu wrote: Tested on Linux/x86-64. OK for trunk? + /* FIXME:

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread H.J. Lu
On Tue, Apr 26, 2016 at 8:05 AM, Ilya Enkovich wrote: > 2016-04-26 17:55 GMT+03:00 H.J. Lu : >> On Tue, Apr 26, 2016 at 7:15 AM, Ilya Enkovich >> wrote: >>> 2016-04-26 17:07 GMT+03:00 H.J. Lu : On Mon, Apr 25, 2016 at 9:13 AM, Ilya Enkovich wrote: > 2016-04-25 18:27 GMT+03:00 H.J

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread Ilya Enkovich
2016-04-26 17:55 GMT+03:00 H.J. Lu : > On Tue, Apr 26, 2016 at 7:15 AM, Ilya Enkovich wrote: >> 2016-04-26 17:07 GMT+03:00 H.J. Lu : >>> On Mon, Apr 25, 2016 at 9:13 AM, Ilya Enkovich >>> wrote: 2016-04-25 18:27 GMT+03:00 H.J. Lu : > > Ilya, can you take a look? > > Thanks.

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread H.J. Lu
On Tue, Apr 26, 2016 at 7:15 AM, Ilya Enkovich wrote: > 2016-04-26 17:07 GMT+03:00 H.J. Lu : >> On Mon, Apr 25, 2016 at 9:13 AM, Ilya Enkovich >> wrote: >>> 2016-04-25 18:27 GMT+03:00 H.J. Lu : Ilya, can you take a look? Thanks. -- H.J. >>> >>> Hi, >>> >>> Algo

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread Ilya Enkovich
2016-04-26 17:07 GMT+03:00 H.J. Lu : > On Mon, Apr 25, 2016 at 9:13 AM, Ilya Enkovich wrote: >> 2016-04-25 18:27 GMT+03:00 H.J. Lu : >>> >>> Ilya, can you take a look? >>> >>> Thanks. >>> >>> -- >>> H.J. >> >> Hi, >> >> Algorithmic part of the patch looks OK to me except the following piece of >>

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread H.J. Lu
On Mon, Apr 25, 2016 at 9:13 AM, Ilya Enkovich wrote: > 2016-04-25 18:27 GMT+03:00 H.J. Lu : >> >> Ilya, can you take a look? >> >> Thanks. >> >> -- >> H.J. > > Hi, > > Algorithmic part of the patch looks OK to me except the following piece of > code. > > +/* Check REF's chain to add new insns in

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread Richard Biener
On Tue, 26 Apr 2016, Uros Bizjak wrote: > On Tue, Apr 26, 2016 at 11:17 AM, Richard Biener wrote: > > On Mon, 25 Apr 2016, Uros Bizjak wrote: > > > >> On Mon, Apr 25, 2016 at 4:47 PM, H.J. Lu wrote: > >> > On Mon, Apr 25, 2016 at 7:18 AM, Uros Bizjak wrote: > >> >> On Mon, Apr 25, 2016 at 2:51

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread Uros Bizjak
On Tue, Apr 26, 2016 at 11:17 AM, Richard Biener wrote: > On Mon, 25 Apr 2016, Uros Bizjak wrote: > >> On Mon, Apr 25, 2016 at 4:47 PM, H.J. Lu wrote: >> > On Mon, Apr 25, 2016 at 7:18 AM, Uros Bizjak wrote: >> >> On Mon, Apr 25, 2016 at 2:51 PM, H.J. Lu wrote: >> >>> Tested on Linux/x86-64. O

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-26 Thread Richard Biener
On Mon, 25 Apr 2016, Uros Bizjak wrote: > On Mon, Apr 25, 2016 at 4:47 PM, H.J. Lu wrote: > > On Mon, Apr 25, 2016 at 7:18 AM, Uros Bizjak wrote: > >> On Mon, Apr 25, 2016 at 2:51 PM, H.J. Lu wrote: > >>> Tested on Linux/x86-64. OK for trunk? > >> > >>> + /* FIXME: Since the CSE pass may chan

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-25 Thread Ilya Enkovich
2016-04-25 18:27 GMT+03:00 H.J. Lu : > > Ilya, can you take a look? > > Thanks. > > -- > H.J. Hi, Algorithmic part of the patch looks OK to me except the following piece of code. +/* Check REF's chain to add new insns into a queue + and find registers requiring conversion. */ Comment is wron

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-25 Thread H.J. Lu
On Mon, Apr 25, 2016 at 8:27 AM, H.J. Lu wrote: > On Mon, Apr 25, 2016 at 8:10 AM, Uros Bizjak wrote: >> On Mon, Apr 25, 2016 at 4:47 PM, H.J. Lu wrote: >>> On Mon, Apr 25, 2016 at 7:18 AM, Uros Bizjak wrote: On Mon, Apr 25, 2016 at 2:51 PM, H.J. Lu wrote: > Tested on Linux/x86-64. O

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-25 Thread H.J. Lu
On Mon, Apr 25, 2016 at 8:10 AM, Uros Bizjak wrote: > On Mon, Apr 25, 2016 at 4:47 PM, H.J. Lu wrote: >> On Mon, Apr 25, 2016 at 7:18 AM, Uros Bizjak wrote: >>> On Mon, Apr 25, 2016 at 2:51 PM, H.J. Lu wrote: Tested on Linux/x86-64. OK for trunk? >>> + /* FIXME: Since the CSE pass m

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-25 Thread Uros Bizjak
On Mon, Apr 25, 2016 at 4:47 PM, H.J. Lu wrote: > On Mon, Apr 25, 2016 at 7:18 AM, Uros Bizjak wrote: >> On Mon, Apr 25, 2016 at 2:51 PM, H.J. Lu wrote: >>> Tested on Linux/x86-64. OK for trunk? >> >>> + /* FIXME: Since the CSE pass may change dominance info, which isn't >>> + expected by

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-25 Thread H.J. Lu
On Mon, Apr 25, 2016 at 7:18 AM, Uros Bizjak wrote: > On Mon, Apr 25, 2016 at 2:51 PM, H.J. Lu wrote: >> Tested on Linux/x86-64. OK for trunk? > >> + /* FIXME: Since the CSE pass may change dominance info, which isn't >> + expected by the fwprop pass, call free_dominance_info to >> + in

Re: [PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-25 Thread Uros Bizjak
On Mon, Apr 25, 2016 at 2:51 PM, H.J. Lu wrote: > Tested on Linux/x86-64. OK for trunk? > + /* FIXME: Since the CSE pass may change dominance info, which isn't > + expected by the fwprop pass, call free_dominance_info to > + invalidate dominance info. Otherwise, the fwprop pass may cra

[PATCH] PR target/70155: Use SSE for TImode load/store

2016-04-25 Thread H.J. Lu
Tested on Linux/x86-64. OK for trunk? BTW, I have a followup patch to use SSE for TImode bitwise operation. H.J. 128-bit SSE load and store instructions can be used for load and store of 128-bit integers if they are the only operations on 128-bit integers. To convert load and store of 128-b