Re: [PATCH] PR target/65248: Copy relocation against protected symbol doesn't work

2015-03-27 Thread H.J. Lu
On Fri, Mar 27, 2015 at 10:19 AM, Richard Henderson wrote: > On 03/06/2015 05:42 AM, H.J. Lu wrote: >> gcc/ >> >> PR target/65248 >> * output.h (default_binds_local_p_2): New. >> * varasm.c (default_binds_local_p_2): Renamed to ... >> (default_binds_local_p_3): This. Don't

Re: [PATCH] PR target/65248: Copy relocation against protected symbol doesn't work

2015-03-27 Thread Richard Henderson
On 03/06/2015 05:42 AM, H.J. Lu wrote: > gcc/ > > PR target/65248 > * output.h (default_binds_local_p_2): New. > * varasm.c (default_binds_local_p_2): Renamed to ... > (default_binds_local_p_3): This. Don't return true on protected > data symbol if protected data may

Re: [PATCH] PR target/65248: Copy relocation against protected symbol doesn't work

2015-03-27 Thread Uros Bizjak
On Fri, Mar 27, 2015 at 5:52 PM, H.J. Lu wrote: > On Wed, Mar 18, 2015 at 12:11 PM, H.J. Lu wrote: >> On Wed, Mar 18, 2015 at 11:58 AM, Mike Stump wrote: >>> On Mar 18, 2015, at 2:55 AM, Uros Bizjak wrote: > Here is the updated patch with testcases. Tested on Linux/x86. OK > for

Re: [PATCH] PR target/65248: Copy relocation against protected symbol doesn't work

2015-03-27 Thread H.J. Lu
On Wed, Mar 18, 2015 at 12:11 PM, H.J. Lu wrote: > On Wed, Mar 18, 2015 at 11:58 AM, Mike Stump wrote: >> On Mar 18, 2015, at 2:55 AM, Uros Bizjak wrote: >>> Here is the updated patch with testcases. Tested on Linux/x86. OK for trunk? >> >>> This patch needs global reviewer approval

Re: [PATCH] PR target/65248: Copy relocation against protected symbol doesn't work

2015-03-18 Thread H.J. Lu
On Wed, Mar 18, 2015 at 11:58 AM, Mike Stump wrote: > On Mar 18, 2015, at 2:55 AM, Uros Bizjak wrote: >> >>> Here is the updated patch with testcases. Tested on Linux/x86. OK >>> for trunk? > >> This patch needs global reviewer approval (I have added Jakub to CC) >> and Darwin maintainer approv

Re: [PATCH] PR target/65248: Copy relocation against protected symbol doesn't work

2015-03-18 Thread Mike Stump
On Mar 18, 2015, at 2:55 AM, Uros Bizjak wrote: > >> Here is the updated patch with testcases. Tested on Linux/x86. OK >> for trunk? > This patch needs global reviewer approval (I have added Jakub to CC) > and Darwin maintainer approval. So, my concern would be this, does the bug also impact

Re: [PATCH] PR target/65248: Copy relocation against protected symbol doesn't work

2015-03-18 Thread Uros Bizjak
On Fri, Mar 6, 2015 at 2:42 PM, H.J. Lu wrote: > On Thu, Mar 05, 2015 at 05:31:51PM -0800, H.J. Lu wrote: >> Protected data symbol means that it can't be pre-emptied. It doesn't mean >> its address won't be external. This is true for pointer to protected >> function. With copy relocation, addre

Re: [PATCH] PR target/65248: Copy relocation against protected symbol doesn't work

2015-03-06 Thread H.J. Lu
On Thu, Mar 05, 2015 at 05:31:51PM -0800, H.J. Lu wrote: > Protected data symbol means that it can't be pre-emptied. It doesn't mean > its address won't be external. This is true for pointer to protected > function. With copy relocation, address of protected data defined in the > shared library

[PATCH] PR target/65248: Copy relocation against protected symbol doesn't work

2015-03-05 Thread H.J. Lu
Protected data symbol means that it can't be pre-emptied. It doesn't mean its address won't be external. This is true for pointer to protected function. With copy relocation, address of protected data defined in the shared library may also be external. We only know that for sure at run-time. T