Re: [PATCH] PR target/65242, Fix powerpc abort in gen_add2_insn

2015-03-12 Thread Jeff Law
On 03/11/15 08:44, David Edelsohn wrote: On Mon, Mar 9, 2015 at 7:30 PM, Michael Meissner wrote: This bug was one I unfortunately introduced with the -mupper-regs support. If the reload pass needed to reload a PLUS operation (for example, due to using odd address with the LD/STD instructions),

Re: [PATCH] PR target/65242, Fix powerpc abort in gen_add2_insn

2015-03-11 Thread David Edelsohn
Jeff, I completely agree. The example exposed a problematic alternative in the pattern and I would like to fix a latent problem, in addition to Mike's patch. Thanks, David On Wed, Mar 11, 2015 at 12:05 PM, Jeff Law wrote: > On 03/11/15 08:44, David Edelsohn wrote: >> >> On Mon, Mar 9, 2015 at

Re: [PATCH] PR target/65242, Fix powerpc abort in gen_add2_insn

2015-03-11 Thread David Edelsohn
On Mon, Mar 9, 2015 at 7:30 PM, Michael Meissner wrote: > This bug was one I unfortunately introduced with the -mupper-regs support. If > the reload pass needed to reload a PLUS operation (for example, due to using > odd address with the LD/STD instructions), it would go through all of the > regi

[PATCH] PR target/65242, Fix powerpc abort in gen_add2_insn

2015-03-09 Thread Michael Meissner
This bug was one I unfortunately introduced with the -mupper-regs support. If the reload pass needed to reload a PLUS operation (for example, due to using odd address with the LD/STD instructions), it would go through all of the registers you could load DImode into, and see if it is a preferred re