Re: [PATCH] PR target/105325, Make load/cmp fusion know about prefixed loads

2023-03-24 Thread Michael Meissner via Gcc-patches
On Thu, Mar 23, 2023 at 04:10:22PM +0800, Kewen.Lin wrote: > Hi Mike, > > Thanks for fixing this, some minor comments are inlined below. > > on 2023/3/22 07:53, Michael Meissner wrote: > > The issue with the bug is the power10 load GPR + cmpi -1/0/1 fusion > > optimization generates illegal assem

Re: [PATCH] PR target/105325, Make load/cmp fusion know about prefixed loads

2023-03-23 Thread Kewen.Lin via Gcc-patches
Hi Mike, Thanks for fixing this, some minor comments are inlined below. on 2023/3/22 07:53, Michael Meissner wrote: > The issue with the bug is the power10 load GPR + cmpi -1/0/1 fusion > optimization generates illegal assembler code. > > Ultimately the code was dying because the fusion load + c

[PATCH] PR target/105325, Make load/cmp fusion know about prefixed loads

2023-03-21 Thread Michael Meissner via Gcc-patches
The issue with the bug is the power10 load GPR + cmpi -1/0/1 fusion optimization generates illegal assembler code. Ultimately the code was dying because the fusion load + compare -1/0/1 patterns did not handle the possibility that the load might be prefixed. The main cause is the constraints for