Re: [PATCH] PR other/69006: fix extra newlines after diagnostics (v2)

2016-01-26 Thread David Malcolm
On Tue, 2016-01-26 at 12:18 +0100, Bernd Schmidt wrote: > On 01/25/2016 09:13 PM, David Malcolm wrote: > > Here's an updated version of the patch. > > Thanks! > > > Instead of testing one particular kind of output via a plugin, > > this version of the patch adds code to gcc-dg-prune to issue a >

Re: [PATCH] PR other/69006: fix extra newlines after diagnostics (v2)

2016-01-26 Thread Bernd Schmidt
On 01/25/2016 09:13 PM, David Malcolm wrote: Here's an updated version of the patch. Thanks! Instead of testing one particular kind of output via a plugin, this version of the patch adds code to gcc-dg-prune to issue a FAIL for any testcase containing blank lines, with a new dg-allow-blank

[PATCH] PR other/69006: fix extra newlines after diagnostics (v2)

2016-01-25 Thread David Malcolm
Here's an updated version of the patch. On Wed, 2016-01-13 at 18:32 +0100, Bernd Schmidt wrote: > On 01/13/2016 01:57 AM, David Malcolm wrote: > > There are five places in trunk that can call diagnostic_show_locus. > > I'd kind of like to see before/after example output for all of these, to > make

Re: [PATCH] PR other/69006: fix extra newlines after diagnostics

2016-01-13 Thread Bernd Schmidt
On 01/13/2016 01:57 AM, David Malcolm wrote: There are five places in trunk that can call diagnostic_show_locus. I'd kind of like to see before/after example output for all of these, to make sure that we are indeed removing only unnecessary newlines. The final caller of diagnostic_show_locu

[PATCH] PR other/69006: fix extra newlines after diagnostics

2016-01-12 Thread David Malcolm
Before r229884 (aka f04790107a32653aa7adbd24967b908c8a08), diagnostic_show_locus did not emit a newline for the line containing the caret, whereas the new implementation in r229884 does emit a newline for the final line it emits. PR other/69006 notes that this leads to undesired extra newlines