Re: [PATCH] PR lto/61048 Define missed builtins on demand

2014-10-15 Thread Manuel López-Ibáñez
> You need to handle them in lto-opts.c and output them to the existing option > section. Not sure why they don't appear there already - ah, because of > > /* Also drop all options that are handled by the driver as well, > which includes things like -o and -v or -fhelp for example.

Re: [PATCH] PR lto/61048 Define missed builtins on demand

2014-10-15 Thread Jakub Jelinek
On Wed, Oct 15, 2014 at 12:41:47PM +0400, Ilya Palachev wrote: > >Yep. As with other options this looks like it needs "conservative" > >merging. Which might be more involved than for other cases - but well... > > > >Look at existing examples in gcc/lto-opts.c and gcc/lto-wrapper.c. > > I have se

Re: [PATCH] PR lto/61048 Define missed builtins on demand

2014-10-15 Thread Richard Biener
On Wed, Oct 15, 2014 at 10:18 AM, Ilya Palachev wrote: > On 15.10.2014 10:59, Jakub Jelinek wrote: >> >> On Tue, Oct 14, 2014 at 08:39:40PM +0400, Ilya Palachev wrote: >>> >>> Attached patch fixes PR lto/61048 - >>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61048 >> >> >> Given that the patch j

Re: [PATCH] PR lto/61048 Define missed builtins on demand

2014-10-15 Thread Ilya Palachev
On 15.10.2014 12:09, Richard Biener wrote: On Wed, Oct 15, 2014 at 8:59 AM, Jakub Jelinek wrote: On Tue, Oct 14, 2014 at 08:39:40PM +0400, Ilya Palachev wrote: Attached patch fixes PR lto/61048 - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61048 Given that the patch just replaces an ICE wit

Re: [PATCH] PR lto/61048 Define missed builtins on demand

2014-10-15 Thread Ilya Palachev
On 15.10.2014 10:59, Jakub Jelinek wrote: On Tue, Oct 14, 2014 at 08:39:40PM +0400, Ilya Palachev wrote: Attached patch fixes PR lto/61048 - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61048 Given that the patch just replaces an ICE with a necessary link failure, I'd say it is done at the wro

Re: [PATCH] PR lto/61048 Define missed builtins on demand

2014-10-15 Thread Richard Biener
On Wed, Oct 15, 2014 at 8:59 AM, Jakub Jelinek wrote: > On Tue, Oct 14, 2014 at 08:39:40PM +0400, Ilya Palachev wrote: >> Attached patch fixes PR lto/61048 - >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61048 > > Given that the patch just replaces an ICE with a necessary link failure, I'd > sa

Re: [PATCH] PR lto/61048 Define missed builtins on demand

2014-10-15 Thread Jakub Jelinek
On Tue, Oct 14, 2014 at 08:39:40PM +0400, Ilya Palachev wrote: > Attached patch fixes PR lto/61048 - > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61048 Given that the patch just replaces an ICE with a necessary link failure, I'd say it is done at the wrong place, instead during the LTO option ha

[PATCH] PR lto/61048 Define missed builtins on demand

2014-10-14 Thread Ilya Palachev
Hi all, Attached patch fixes PR lto/61048 - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61048 The reason of failure was that the builtin information structure was not initialized properly at the link stage. The failed assertion was caused by missing builtin declaration ( BUILT_IN_ASAN_AFTER