Re: [PATCH] PR libstdc++/90920 restore previous checks for empty ranges

2019-06-21 Thread Jonathan Wakely
On 20/06/19 00:00 +0100, Jonathan Wakely wrote: The change in r263433 broke the contract of the __rotate functions, by no longer accepting empty ranges. That means that callers which inlined the old version of std::rotate (without checks) that end up linking to a new definition of std::__rotate (

[PATCH] PR libstdc++/90920 restore previous checks for empty ranges

2019-06-19 Thread Jonathan Wakely
The change in r263433 broke the contract of the __rotate functions, by no longer accepting empty ranges. That means that callers which inlined the old version of std::rotate (without checks) that end up linking to a new definition of std::__rotate (also without checks) could perform a divide by ze