Re: [PATCH] PR libstdc++/85184 remove debug assertions from std::variant

2019-04-03 Thread Jonathan Wakely
On Wed, 3 Apr 2019 at 11:04, Ville Voutilainen wrote: > > On Wed, 3 Apr 2019 at 12:48, Jonathan Wakely wrote: > > > > The __glibcxx_assert macro should be used to check preconditions that > > users must meet, not to check postconditions that the implementation > > must meet. We have tests to veri

Re: [PATCH] PR libstdc++/85184 remove debug assertions from std::variant

2019-04-03 Thread Ville Voutilainen
On Wed, 3 Apr 2019 at 13:04, Ville Voutilainen wrote: > > On Wed, 3 Apr 2019 at 12:48, Jonathan Wakely wrote: > > > > The __glibcxx_assert macro should be used to check preconditions that > > users must meet, not to check postconditions that the implementation > > must meet. We have tests to veri

Re: [PATCH] PR libstdc++/85184 remove debug assertions from std::variant

2019-04-03 Thread Ville Voutilainen
On Wed, 3 Apr 2019 at 12:48, Jonathan Wakely wrote: > > The __glibcxx_assert macro should be used to check preconditions that > users must meet, not to check postconditions that the implementation > must meet. We have tests to verify std::variant meets its > postconditions, users shouldn't pay for

[PATCH] PR libstdc++/85184 remove debug assertions from std::variant

2019-04-03 Thread Jonathan Wakely
The __glibcxx_assert macro should be used to check preconditions that users must meet, not to check postconditions that the implementation must meet. We have tests to verify std::variant meets its postconditions, users shouldn't pay for those checks at runtime. PR libstdc++/85184