Re: [PATCH] PR fortran/69101 -- IEEE_SELECTED_REAL_KIND part I

2019-01-20 Thread Steve Kargl
On Sun, Jan 20, 2019 at 05:04:24PM -0800, Steve Kargl wrote: > On Tue, Jan 08, 2019 at 10:27:25PM +0100, Thomas Koenig wrote: > > Hi Steve, > > > > > Well, that was quick. Moving code around is problematic. > > > > Thanks for checking. The patch is OK for trunk. > > > > Thanks. I decided to s

Re: [PATCH] PR fortran/69101 -- IEEE_SELECTED_REAL_KIND part I

2019-01-20 Thread Steve Kargl
On Tue, Jan 08, 2019 at 10:27:25PM +0100, Thomas Koenig wrote: > Hi Steve, > > > Well, that was quick. Moving code around is problematic. > > Thanks for checking. The patch is OK for trunk. > Thanks. I decided to see if long term approach would work. It almost does. The attached patch put ie

Re: [PATCH] PR fortran/69101 -- IEEE_SELECTED_REAL_KIND part I

2019-01-08 Thread Thomas Koenig
Hi Steve, Well, that was quick. Moving code around is problematic. Thanks for checking. The patch is OK for trunk. Regards Thomas

Re: [PATCH] PR fortran/69101 -- IEEE_SELECTED_REAL_KIND part I

2019-01-05 Thread Steve Kargl
On Sat, Jan 05, 2019 at 09:22:34AM -0800, Steve Kargl wrote: > On Sat, Jan 05, 2019 at 01:23:14PM +0100, Thomas Koenig wrote: > > > > Maybe it would be better to put the checking and argument reordering > > into its own routine (something like gfc_check_minloc_maxloc in > > check.c) so all three a

Re: [PATCH] PR fortran/69101 -- IEEE_SELECTED_REAL_KIND part I

2019-01-05 Thread Steve Kargl
On Sat, Jan 05, 2019 at 01:23:14PM +0100, Thomas Koenig wrote: > > Maybe it would be better to put the checking and argument reordering > into its own routine (something like gfc_check_minloc_maxloc in > check.c) so all three arguments would be present, with an > expression possibly containing NUL

Re: [PATCH] PR fortran/69101 -- IEEE_SELECTED_REAL_KIND part I

2019-01-05 Thread Thomas Koenig
Hi Steve, thanks for taking this on! Maybe it would be better to put the checking and argument reordering into its own routine (something like gfc_check_minloc_maxloc in check.c) so all three arguments would be present, with an expression possibly containing NULL, for the later routines. This co

[PATCH] PR fortran/69101 -- IEEE_SELECTED_REAL_KIND part I

2019-01-04 Thread Steve Kargl
2019-01-04 Steven G. Kargl PR fortran/69101 * expr.c (gfc_check_init_expr): If errors were emitted during simplification of ieee_selected_real_kind(), clear any additional errors anre return false. * simplify.c (simplify_ieee_selected_real_kind): make