Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing

2015-08-03 Thread Steve Kargl
On Thu, Jul 30, 2015 at 04:08:47PM +0200, Mikael Morin wrote: > Le 29/07/2015 18:45, Steve Kargl a écrit : > > > > This builds and passes regression testing on x86_64-*-freebsd. > > OP found the problem by running the sanatizers. I don't > > know how to build gcc with this as a build option. I'll

Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing

2015-07-30 Thread Mikael Morin
Le 29/07/2015 18:45, Steve Kargl a écrit : On Wed, Jul 29, 2015 at 02:04:12PM +0200, Richard Biener wrote: On Wed, Jul 29, 2015 at 1:59 PM, Mikael Morin wrote: Le 29/07/2015 13:22, Richard Biener a écrit : On Wed, Jul 29, 2015 at 11:34 AM, Mikael Morin wrote: Le 29/07/2015 10:26, Richard

Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing

2015-07-29 Thread Steve Kargl
On Wed, Jul 29, 2015 at 02:04:12PM +0200, Richard Biener wrote: > On Wed, Jul 29, 2015 at 1:59 PM, Mikael Morin wrote: > > Le 29/07/2015 13:22, Richard Biener a écrit : > >> > >> On Wed, Jul 29, 2015 at 11:34 AM, Mikael Morin > >> wrote: > >>> > >>> Le 29/07/2015 10:26, Richard Biener a écrit : >

Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing

2015-07-29 Thread Richard Biener
On Wed, Jul 29, 2015 at 1:59 PM, Mikael Morin wrote: > Le 29/07/2015 13:22, Richard Biener a écrit : >> >> On Wed, Jul 29, 2015 at 11:34 AM, Mikael Morin >> wrote: >>> >>> Le 29/07/2015 10:26, Richard Biener a écrit : >> >> >> Did you try using vec_safe_splice? Tha

Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing

2015-07-29 Thread Mikael Morin
Le 29/07/2015 13:22, Richard Biener a écrit : On Wed, Jul 29, 2015 at 11:34 AM, Mikael Morin wrote: Le 29/07/2015 10:26, Richard Biener a écrit : Did you try using vec_safe_splice? That handles NULL retargs, not NULL or empty arglist. I think retargs is NULL. Not if the patch fixes any

Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing

2015-07-29 Thread Richard Biener
On Wed, Jul 29, 2015 at 11:34 AM, Mikael Morin wrote: > Le 29/07/2015 10:26, Richard Biener a écrit : Did you try using vec_safe_splice? >> >> >> That handles NULL retargs, not NULL or empty arglist. >> > I think retargs is NULL. Not if the patch fixes anything. Richard.

Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing

2015-07-29 Thread Mikael Morin
Le 29/07/2015 10:26, Richard Biener a écrit : Did you try using vec_safe_splice? That handles NULL retargs, not NULL or empty arglist. I think retargs is NULL.

Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing

2015-07-29 Thread Richard Biener
On Tue, Jul 28, 2015 at 3:19 PM, Steve Kargl wrote: > On Tue, Jul 28, 2015 at 03:04:52PM +0200, Mikael Morin wrote: >> Le 21/07/2015 21:08, Steve Kargl a ?crit : >> > When C++ was injected into trans-expr.c in the form of vec, >> > it seems whomever did the conversion to vec forgot to check >> > f

Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing

2015-07-28 Thread Steve Kargl
On Tue, Jul 28, 2015 at 03:04:52PM +0200, Mikael Morin wrote: > Le 21/07/2015 21:08, Steve Kargl a ?crit : > > When C++ was injected into trans-expr.c in the form of vec, > > it seems whomever did the conversion to vec forgot to check > > for a NULL C++ thing. This patch seems to avoid the problem

Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing

2015-07-28 Thread Mikael Morin
Le 21/07/2015 21:08, Steve Kargl a écrit : When C++ was injected into trans-expr.c in the form of vec, it seems whomever did the conversion to vec forgot to check for a NULL C++ thing. This patch seems to avoid the problem, but having zero knowledge of C++ I could be wrong. OK for trunk? 2015-

[PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing

2015-07-21 Thread Steve Kargl
When C++ was injected into trans-expr.c in the form of vec, it seems whomever did the conversion to vec forgot to check for a NULL C++ thing. This patch seems to avoid the problem, but having zero knowledge of C++ I could be wrong. OK for trunk? 2015-07-21 Steven G. Kargl PR fortran/