Re: [PATCH] PR driver/69779: fix bogus cleanup code used by libgccjit affecting s390x

2016-02-12 Thread Jeff Law
On 02/12/2016 11:12 AM, David Malcolm wrote: The problem is that struct spec_list's "name" field is declared const: const char *name;/* name of the spec. */ and likewise for the "name" field within struct spec_list_1: const char *const name; Some are statically allocated,

Re: [PATCH] PR driver/69779: fix bogus cleanup code used by libgccjit affecting s390x

2016-02-12 Thread David Malcolm
On Fri, 2016-02-12 at 00:51 -0700, Jeff Law wrote: > On 02/11/2016 10:12 PM, David Malcolm wrote: > > In r227188 I introduced driver::finalize () which resets > > all state within gcc.c, allowing the driver code to embedded > > inside libgccjit and run repeatedly in-process. > > > > Running this o

Re: [PATCH] PR driver/69779: fix bogus cleanup code used by libgccjit affecting s390x

2016-02-11 Thread Jeff Law
On 02/11/2016 10:12 PM, David Malcolm wrote: In r227188 I introduced driver::finalize () which resets all state within gcc.c, allowing the driver code to embedded inside libgccjit and run repeatedly in-process. Running this on s390x revealed a bug in this cleanup: I was cleaning up "specs" via:

[PATCH] PR driver/69779: fix bogus cleanup code used by libgccjit affecting s390x

2016-02-11 Thread David Malcolm
In r227188 I introduced driver::finalize () which resets all state within gcc.c, allowing the driver code to embedded inside libgccjit and run repeatedly in-process. Running this on s390x revealed a bug in this cleanup: I was cleaning up "specs" via: XDELETEVEC (specs); and this wa