Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread H.J. Lu via Gcc-patches
On Tue, Jul 28, 2020 at 11:47 AM Simon Marchi wrote: > > On 2020-07-28 2:31 p.m., H.J. Lu wrote: > >>> Unlike gdb, binutils should have as few external depecies as possible. > >>> debuginfod brings in some so many external depecies. > >> > >> I'm not a binutils maintainer, so that's not my role to

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread Simon Marchi
On 2020-07-28 2:31 p.m., H.J. Lu wrote: >>> Unlike gdb, binutils should have as few external depecies as possible. >>> debuginfod brings in some so many external depecies. >> >> I'm not a binutils maintainer, so that's not my role to decide about that >> tradeoff... but we are talking about having

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread H.J. Lu via Gcc-patches
On Tue, Jul 28, 2020 at 10:43 AM Simon Marchi wrote: > > On 2020-07-28 1:26 p.m., H.J. Lu wrote: > > On Tue, Jul 28, 2020 at 9:28 AM Simon Marchi wrote: > >> > >> On 2020-07-28 12:07 p.m., H.J. Lu via Gdb-patches wrote: > >>> What doesn't work with my pkg.m4 change? > >> > >> (1) It deviates from

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread Simon Marchi
On 2020-07-28 1:26 p.m., H.J. Lu wrote: > On Tue, Jul 28, 2020 at 9:28 AM Simon Marchi wrote: >> >> On 2020-07-28 12:07 p.m., H.J. Lu via Gdb-patches wrote: >>> What doesn't work with my pkg.m4 change? >> >> (1) It deviates from upstream. I don't think we should do this unless >> absolutely n

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread H.J. Lu via Gcc-patches
On Tue, Jul 28, 2020 at 9:28 AM Simon Marchi wrote: > > On 2020-07-28 12:07 p.m., H.J. Lu via Gdb-patches wrote: > > What doesn't work with my pkg.m4 change? > > (1) It deviates from upstream. I don't think we should do this unless > absolutely needed. That's not the case here, the change is

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread Simon Marchi
On 2020-07-28 12:07 p.m., H.J. Lu via Gdb-patches wrote: > What doesn't work with my pkg.m4 change? (1) It deviates from upstream. I don't think we should do this unless absolutely needed. That's not the case here, the change is just there because you don't want to set up pkg-config prop

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread H.J. Lu via Gcc-patches
On Tue, Jul 28, 2020 at 8:13 AM Simon Marchi wrote: > > On 2020-07-28 11:05 a.m., H.J. Lu via Gdb-patches wrote: > >> Can you clarify how this magic works, is this standard autoconf? Because > >> I am trying this > >> on Fedora, so pretty much the same setup as you, and I don't see this > >> be

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread Simon Marchi
On 2020-07-28 11:05 a.m., H.J. Lu via Gdb-patches wrote: >> Can you clarify how this magic works, is this standard autoconf? Because I >> am trying this >> on Fedora, so pretty much the same setup as you, and I don't see this >> behavior: >> >> $ /home/simark/src/binutils-gdb/configure CC="gcc -

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread H.J. Lu via Gcc-patches
On Tue, Jul 28, 2020 at 7:34 AM Simon Marchi wrote: > > On 2020-07-28 10:11 a.m., H.J. Lu wrote: > > On Tue, Jul 28, 2020 at 7:01 AM Simon Marchi wrote: > >> > >> On 2020-07-28 9:56 a.m., H.J. Lu wrote: > >>> On Tue, Jul 28, 2020 at 6:51 AM Andreas Schwab > >>> wrote: > > On Jul 28 20

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread Andreas Schwab
On Jul 28 2020, H.J. Lu wrote: > My system supports both -m32 and -m64. My system also supports m68k. That doesn't make it "native". $ file hello.m68k hello.m68k: ELF 32-bit MSB executable, Motorola m68k, 68020, version 1 (SYSV), dynamically linked, interpreter /lib/ld., for GNU/Linux 2.6.32,

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread Simon Marchi
On 2020-07-28 10:11 a.m., H.J. Lu wrote: > On Tue, Jul 28, 2020 at 7:01 AM Simon Marchi wrote: >> >> On 2020-07-28 9:56 a.m., H.J. Lu wrote: >>> On Tue, Jul 28, 2020 at 6:51 AM Andreas Schwab >>> wrote: On Jul 28 2020, H.J. Lu via Binutils wrote: > On x86, the native GCC can s

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread H.J. Lu via Gcc-patches
On Tue, Jul 28, 2020 at 7:01 AM Simon Marchi wrote: > > On 2020-07-28 9:56 a.m., H.J. Lu wrote: > > On Tue, Jul 28, 2020 at 6:51 AM Andreas Schwab > > wrote: > >> > >> On Jul 28 2020, H.J. Lu via Binutils wrote: > >> > >>> On x86, the native GCC can support -m32 and -m64. "gcc -m32" or "gcc >

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread Simon Marchi
On 2020-07-28 9:56 a.m., H.J. Lu wrote: > On Tue, Jul 28, 2020 at 6:51 AM Andreas Schwab wrote: >> >> On Jul 28 2020, H.J. Lu via Binutils wrote: >> >>> On x86, the native GCC can support -m32 and -m64. "gcc -m32" or "gcc -m64" >>> are not cross compiling. >> >> You cannot link -m64 and -m32 tog

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread H.J. Lu via Gcc-patches
On Tue, Jul 28, 2020 at 6:51 AM Andreas Schwab wrote: > > On Jul 28 2020, H.J. Lu via Binutils wrote: > > > On x86, the native GCC can support -m32 and -m64. "gcc -m32" or "gcc -m64" > > are not cross compiling. > > You cannot link -m64 and -m32 together. > > > I didn't set PKG_CONFIG_LIBDIR and

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread Simon Marchi
On 2020-07-28 9:33 a.m., H.J. Lu wrote: > On x86, the native GCC can support -m32 and -m64. "gcc -m32" or "gcc -m64" > are not cross compiling. And how does that make it not cross-compîling? >> Anyway regardless of vocabulary, I don't think there was a problem to begin >> with (not that I blam

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread H.J. Lu via Gcc-patches
On Tue, Jul 28, 2020 at 6:33 AM H.J. Lu wrote: > > On Tue, Jul 28, 2020 at 5:46 AM Simon Marchi wrote: > > > > On 2020-07-28 6:45 a.m., H.J. Lu wrote: > > > On Mon, Jul 27, 2020 at 12:32 PM H.J. Lu wrote: > > >> > > >> On Mon, Jul 27, 2020 at 12:14 PM H.J. Lu wrote: > > >>> > > >>> On Mon, Jul

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread Andreas Schwab
On Jul 28 2020, H.J. Lu via Binutils wrote: > On x86, the native GCC can support -m32 and -m64. "gcc -m32" or "gcc -m64" > are not cross compiling. You cannot link -m64 and -m32 together. > I didn't set PKG_CONFIG_LIBDIR and I don't want to set it. Then use the correct pkg-config for your tar

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread H.J. Lu via Gcc-patches
On Tue, Jul 28, 2020 at 5:46 AM Simon Marchi wrote: > > On 2020-07-28 6:45 a.m., H.J. Lu wrote: > > On Mon, Jul 27, 2020 at 12:32 PM H.J. Lu wrote: > >> > >> On Mon, Jul 27, 2020 at 12:14 PM H.J. Lu wrote: > >>> > >>> On Mon, Jul 27, 2020 at 9:11 AM Aaron Merey wrote: > > On Mon, Jul

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread Mark Wielaard
Hi, On Mon, 2020-07-27 at 12:32 -0700, H.J. Lu via Binutils wrote: > diff --git a/config/pkg.m4 b/config/pkg.m4 > index 13a8890178..45587e97c8 100644 > --- a/config/pkg.m4 > +++ b/config/pkg.m4 > @@ -147,6 +147,12 @@ AC_MSG_CHECKING([for $2]) > _PKG_CONFIG([$1][_CFLAGS], [cflags], [$2]) > _PKG_C

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread Simon Marchi
On 2020-07-28 6:45 a.m., H.J. Lu wrote: > On Mon, Jul 27, 2020 at 12:32 PM H.J. Lu wrote: >> >> On Mon, Jul 27, 2020 at 12:14 PM H.J. Lu wrote: >>> >>> On Mon, Jul 27, 2020 at 9:11 AM Aaron Merey wrote: On Mon, Jul 27, 2020 at 11:32 AM H.J. Lu wrote: > > On Sat, Jul 25, 2020 a

Re: V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-28 Thread H.J. Lu via Gcc-patches
On Mon, Jul 27, 2020 at 12:32 PM H.J. Lu wrote: > > On Mon, Jul 27, 2020 at 12:14 PM H.J. Lu wrote: > > > > On Mon, Jul 27, 2020 at 9:11 AM Aaron Merey wrote: > > > > > > On Mon, Jul 27, 2020 at 11:32 AM H.J. Lu wrote: > > > > > > > > On Sat, Jul 25, 2020 at 9:01 AM H.J. Lu wrote: > > > > > Th

V2 [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-27 Thread H.J. Lu via Gcc-patches
e is the updated patch which only adds AC_TRY_LINK to PKG_CHECK_MODULES to check if $pkg_cv_[]$1[]_LIBS works. -- H.J. From 44682ce298a8ce2b795303d4054ec532847bfcae Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Mon, 27 Jul 2020 08:24:15 -0700 Subject: [PATCH] PKG_CHECK_MODULES: Check if

[PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works

2020-07-27 Thread H.J. Lu via Gcc-patches
comments or objections? -- H.J. From 42d49b1444ad6c8475672f6a6a16810d9e7c15ef Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Mon, 27 Jul 2020 08:24:15 -0700 Subject: [PATCH] PKG_CHECK_MODULES: Check if $pkg_cv_[]$1[]_LIBS works It is quite normal to have headers without library on multi