Re: [PATCH] PHIOPT: Improve replace_phi_edge_with_variable for diamond shapped bb

2023-05-03 Thread Richard Biener via Gcc-patches
On Wed, May 3, 2023 at 8:28 AM Andrew Pinski wrote: > > On Tue, May 2, 2023 at 11:14 PM Richard Biener > wrote: > > > > On Wed, May 3, 2023 at 12:04 AM Andrew Pinski wrote: > > > > > > On Tue, May 2, 2023 at 5:26 AM Richard Biener via Gcc-patches > > > wrote: > > > > > > > > On Sun, Apr 30, 202

Re: [PATCH] PHIOPT: Improve replace_phi_edge_with_variable for diamond shapped bb

2023-05-02 Thread Andrew Pinski via Gcc-patches
On Tue, May 2, 2023 at 11:36 PM Jeff Law wrote: > > > > On 5/3/23 00:27, Andrew Pinski via Gcc-patches wrote: > > On Tue, May 2, 2023 at 11:14 PM Richard Biener > > wrote: > >> > >> On Wed, May 3, 2023 at 12:04 AM Andrew Pinski wrote: > >>> > >>> On Tue, May 2, 2023 at 5:26 AM Richard Biener via

Re: [PATCH] PHIOPT: Improve replace_phi_edge_with_variable for diamond shapped bb

2023-05-02 Thread Jeff Law via Gcc-patches
On 5/3/23 00:27, Andrew Pinski via Gcc-patches wrote: On Tue, May 2, 2023 at 11:14 PM Richard Biener wrote: On Wed, May 3, 2023 at 12:04 AM Andrew Pinski wrote: On Tue, May 2, 2023 at 5:26 AM Richard Biener via Gcc-patches wrote: On Sun, Apr 30, 2023 at 11:14 PM Andrew Pinski via Gcc-

Re: [PATCH] PHIOPT: Improve replace_phi_edge_with_variable for diamond shapped bb

2023-05-02 Thread Andrew Pinski via Gcc-patches
On Tue, May 2, 2023 at 11:14 PM Richard Biener wrote: > > On Wed, May 3, 2023 at 12:04 AM Andrew Pinski wrote: > > > > On Tue, May 2, 2023 at 5:26 AM Richard Biener via Gcc-patches > > wrote: > > > > > > On Sun, Apr 30, 2023 at 11:14 PM Andrew Pinski via Gcc-patches > > > wrote: > > > > > > > >

Re: [PATCH] PHIOPT: Improve replace_phi_edge_with_variable for diamond shapped bb

2023-05-02 Thread Richard Biener via Gcc-patches
On Wed, May 3, 2023 at 12:04 AM Andrew Pinski wrote: > > On Tue, May 2, 2023 at 5:26 AM Richard Biener via Gcc-patches > wrote: > > > > On Sun, Apr 30, 2023 at 11:14 PM Andrew Pinski via Gcc-patches > > wrote: > > > > > > While looking at differences between what minmax_replacement > > > and mat

Re: [PATCH] PHIOPT: Improve replace_phi_edge_with_variable for diamond shapped bb

2023-05-02 Thread Andrew Pinski via Gcc-patches
On Tue, May 2, 2023 at 5:26 AM Richard Biener via Gcc-patches wrote: > > On Sun, Apr 30, 2023 at 11:14 PM Andrew Pinski via Gcc-patches > wrote: > > > > While looking at differences between what minmax_replacement > > and match_simplify_replacement does. I noticed that they sometimes > > chose di

Re: [PATCH] PHIOPT: Improve replace_phi_edge_with_variable for diamond shapped bb

2023-05-02 Thread Richard Biener via Gcc-patches
On Sun, Apr 30, 2023 at 11:14 PM Andrew Pinski via Gcc-patches wrote: > > While looking at differences between what minmax_replacement > and match_simplify_replacement does. I noticed that they sometimes > chose different edges to remove. I decided we should be able to do > better and be able to r

[PATCH] PHIOPT: Improve replace_phi_edge_with_variable for diamond shapped bb

2023-04-30 Thread Andrew Pinski via Gcc-patches
While looking at differences between what minmax_replacement and match_simplify_replacement does. I noticed that they sometimes chose different edges to remove. I decided we should be able to do better and be able to remove both empty basic blocks in the case of match_simplify_replacement as that m