Re: [PATCH] PHIOPT: Improve minmax diamond detection for phiopt1

2023-04-22 Thread Jeff Law via Gcc-patches
On 4/19/23 15:36, Andrew Pinski via Gcc-patches wrote: For diamond bb phi node detection, there is a check to make sure bb1 is not empty. But in the case where bb1 is empty except for a predicate, empty_block_p will still return true but the minmax code handles that case already so there is no

[PATCH] PHIOPT: Improve minmax diamond detection for phiopt1

2023-04-19 Thread Andrew Pinski via Gcc-patches
For diamond bb phi node detection, there is a check to make sure bb1 is not empty. But in the case where bb1 is empty except for a predicate, empty_block_p will still return true but the minmax code handles that case already so there is no reason to check if the basic block is empty. This patch re