Re: [PATCH] Overflow-trapping integer arithmetic routines7code

2020-12-07 Thread Stefan Kanthak
Jeff Law wrote Wednesday, November 25, 2020 7:11 PM: > On 11/25/20 6:18 AM, Stefan Kanthak wrote: >> Jeff Law wrote: [...] >>> My inclination is to leave the overflow checking double-word multiplier >>> as-is. >> See but ff. > Already

Re: [PATCH] Overflow-trapping integer arithmetic routines7code

2020-11-25 Thread Jeff Law via Gcc-patches
On 11/25/20 6:18 AM, Stefan Kanthak wrote: > Jeff Law wrote: > >> On 11/10/20 10:21 AM, Stefan Kanthak wrote: >> So with all that in mind, I installed everything except the bits which have the LIBGCC2_BAD_CODE ifdefs after testing on the various crosses. If you could remove the i

Re: [PATCH] Overflow-trapping integer arithmetic routines7code

2020-11-25 Thread Stefan Kanthak
Jeff Law wrote: > On 11/10/20 10:21 AM, Stefan Kanthak wrote: > >>> So with all that in mind, I installed everything except the bits which >>> have the LIBGCC2_BAD_CODE ifdefs after testing on the various crosses. >>> If you could remove the ifdefs on the abs/mult changes and resubmit them >>> it

Re: [PATCH] Overflow-trapping integer arithmetic routines7code

2020-11-24 Thread Jeff Law via Gcc-patches
On 11/10/20 10:21 AM, Stefan Kanthak wrote: >> So with all that in mind, I installed everything except the bits which >> have the LIBGCC2_BAD_CODE ifdefs after testing on the various crosses. >> If you could remove the ifdefs on the abs/mult changes and resubmit them >> it'd be appreciated. >

Re: [PATCH] Overflow-trapping integer arithmetic routines7code

2020-11-10 Thread Stefan Kanthak
Jeff Law wrote: > On 10/5/20 10:49 AM, Stefan Kanthak wrote: >> The implementation of the functions __absv?i2(), __addv?i3() etc. for >> trapping integer overflow provided in libgcc2.c is rather bad. >> Same for __cmp?i2() and __ucmp?i2() >> >> At least for AMD64 and i386 processors GCC creates a

Re: [PATCH] Overflow-trapping integer arithmetic routines7code

2020-11-10 Thread Jeff Law via Gcc-patches
On 11/10/20 8:57 AM, Jakub Jelinek wrote: > On Tue, Nov 10, 2020 at 08:29:58AM -0700, Jeff Law via Gcc-patches wrote: >> On 10/5/20 10:49 AM, Stefan Kanthak wrote: >>> The implementation of the functions __absv?i2(), __addv?i3() etc. for >>> trapping integer overflow provided in libgcc2.c is rath

Re: [PATCH] Overflow-trapping integer arithmetic routines7code

2020-11-10 Thread Jakub Jelinek via Gcc-patches
On Tue, Nov 10, 2020 at 08:29:58AM -0700, Jeff Law via Gcc-patches wrote: > On 10/5/20 10:49 AM, Stefan Kanthak wrote: > > The implementation of the functions __absv?i2(), __addv?i3() etc. for > > trapping integer overflow provided in libgcc2.c is rather bad. > > Same for __cmp?i2() and __ucmp?i2()

Re: [PATCH] Overflow-trapping integer arithmetic routines7code

2020-11-10 Thread Jeff Law via Gcc-patches
On 10/5/20 10:49 AM, Stefan Kanthak wrote: > The implementation of the functions __absv?i2(), __addv?i3() etc. for > trapping integer overflow provided in libgcc2.c is rather bad. > Same for __cmp?i2() and __ucmp?i2() > > At least for AMD64 and i386 processors GCC creates awful to horrible > code

[PATCH] Overflow-trapping integer arithmetic routines7code

2020-10-05 Thread Stefan Kanthak
The implementation of the functions __absv?i2(), __addv?i3() etc. for trapping integer overflow provided in libgcc2.c is rather bad. Same for __cmp?i2() and __ucmp?i2() At least for AMD64 and i386 processors GCC creates awful to horrible code for them: see