Re: [PATCH] OpenMP: Add support for 'close' in map clause

2021-05-12 Thread Jakub Jelinek via Gcc-patches
On Wed, May 12, 2021 at 04:36:00PM +0200, Marcel Vollweiler wrote: > + c_parser_error (parser, "%<#pragma omp target%> with map-type-" > + "modifier other than % or %" Please just write modifier rather than map-type-modifier > + cp_parser_error (parser, "

Re: [PATCH] OpenMP: Add support for 'close' in map clause

2021-05-12 Thread Marcel Vollweiler
Am 11.05.2021 um 17:20 schrieb Jakub Jelinek: On Tue, May 11, 2021 at 04:27:55PM +0200, Marcel Vollweiler wrote: The usual wording would be "too many % modifiers" Changed for 'always' and 'close' for C and C++. One extra thing, sorry, forgot to mention, for the translators it might be bett

Re: [PATCH] OpenMP: Add support for 'close' in map clause

2021-05-11 Thread Jakub Jelinek via Gcc-patches
On Tue, May 11, 2021 at 05:30:19PM +0200, Tobias Burnus wrote: > On 11.05.21 17:20, Jakub Jelinek via Gcc-patches wrote: > > One extra thing, sorry, forgot to mention, for the translators it might be > > better to use "too many %qs modifiers", "always" (or, "close"). > > That way they can translate

Re: [PATCH] OpenMP: Add support for 'close' in map clause

2021-05-11 Thread Tobias Burnus
On 11.05.21 17:20, Jakub Jelinek via Gcc-patches wrote: One extra thing, sorry, forgot to mention, for the translators it might be better to use "too many %qs modifiers", "always" (or, "close"). That way they can translate it just once instead of twice. That won't work for c_parser_error (pars

Re: [PATCH] OpenMP: Add support for 'close' in map clause

2021-05-11 Thread Jakub Jelinek via Gcc-patches
On Tue, May 11, 2021 at 04:27:55PM +0200, Marcel Vollweiler wrote: > > The usual wording would be > > "too many % modifiers" > > > > Changed for 'always' and 'close' for C and C++. One extra thing, sorry, forgot to mention, for the translators it might be better to use "too many %qs modifiers",

Re: [PATCH] OpenMP: Add support for 'close' in map clause

2021-05-11 Thread Marcel Vollweiler
Am 10.05.2021 um 20:34 schrieb Jakub Jelinek: On Mon, May 10, 2021 at 04:11:39PM +0200, Marcel Vollweiler wrote: @@ -15660,37 +15665,54 @@ c_parser_omp_clause_map (c_parser *parser, tree list) if (!parens.require_open (parser)) return list; - if (c_parser_next_token_is (parser, CPP_

Re: [PATCH] OpenMP: Add support for 'close' in map clause

2021-05-10 Thread Jakub Jelinek via Gcc-patches
On Mon, May 10, 2021 at 04:11:39PM +0200, Marcel Vollweiler wrote: > @@ -15660,37 +15665,54 @@ c_parser_omp_clause_map (c_parser *parser, tree > list) >if (!parens.require_open (parser)) > return list; > > - if (c_parser_next_token_is (parser, CPP_NAME)) > + int always = 0; > + int c

[PATCH] OpenMP: Add support for 'close' in map clause

2021-05-10 Thread Marcel Vollweiler
Hi, This patch adds handling for the map-type-modifier 'close' in the map clause that was introduced with OpenMP 5.0: "The close map-type-modifier is a hint to the runtime to allocate memory close to the target device." In OpenMP 5.0 'close' can be used beside/together with 'always' in a list of