Re: [PATCH] Move std::search into algobase.h

2023-06-02 Thread Jonathan Wakely via Gcc-patches
On Fri, 2 Jun 2023 at 12:30, Jonathan Wakely wrote: > > > On Fri, 2 Jun 2023 at 10:47, François Dumont wrote: > >> Ok, push done. >> > > Thanks. > > >> Even after full rebuild those tests are still UNRESOLVED on my system. >> > What is the error in the log? > > What is your system? How and where

Re: [PATCH] Move std::search into algobase.h

2023-06-02 Thread Jonathan Wakely via Gcc-patches
On Fri, 2 Jun 2023 at 10:47, François Dumont wrote: > Ok, push done. > Thanks. > Even after full rebuild those tests are still UNRESOLVED on my system. > What is the error in the log? What is your system? How and where did you install "OMP"? Does the libgomp directory exist in the GCC build

Re: [PATCH] Move std::search into algobase.h

2023-06-02 Thread François Dumont via Gcc-patches
Ok, push done. Even after full rebuild those tests are still UNRESOLVED on my system. Yes, I also noticed that I could remove this check. I'll propose it later. François On 02/06/2023 09:43, Jonathan Wakely wrote: On Fri, 2 Jun 2023 at 08:33, François Dumont wrote: I haven't been able to

Re: [PATCH] Move std::search into algobase.h

2023-06-02 Thread Jonathan Wakely via Gcc-patches
On Fri, 2 Jun 2023 at 08:33, François Dumont wrote: > I haven't been able to reproduce so far. > > Here is however a patch that I think will fix the problem. At least > failing tests are UNRESOLVED on my system. > > libstdc++: Fix broken _GLIBCXX_PARALLEL mode > > Add missing include in .

Re: [PATCH] Move std::search into algobase.h

2023-06-02 Thread François Dumont via Gcc-patches
I haven't been able to reproduce so far. Here is however a patch that I think will fix the problem. At least failing tests are UNRESOLVED on my system.     libstdc++: Fix broken _GLIBCXX_PARALLEL mode     Add missing include in .     Detect availability of in tests needing it to make them

Re: [PATCH] Move std::search into algobase.h

2023-06-01 Thread Jonathan Wakely via Gcc-patches
On Thu, 1 Jun 2023, 21:37 François Dumont via Libstdc++, < libstd...@gcc.gnu.org> wrote: > It's of course not as easy as I thought. > > I would never have detected this problem on my system because I'm > missing omp.h. > > I've implemented and added a: > > // { dg-require-effective-target omp } >

Re: [PATCH] Move std::search into algobase.h

2023-06-01 Thread François Dumont via Gcc-patches
It's of course not as easy as I thought. I would never have detected this problem on my system because I'm missing omp.h. I've implemented and added a: // { dg-require-effective-target omp } so that now those tests are UNRESOLVED rather than PASS. Now I've install OMP and try to rebuild lib

Re: [PATCH] Move std::search into algobase.h

2023-06-01 Thread François Dumont via Gcc-patches
Sorry, I had fully tested the move from bits/stl_algo.h to bits/stl_algobase.h. But it appears that the script I used to run the tests after the other move has not done what I expected. I'll provide the patch shortly. Le jeu. 1 juin 2023 à 14:06, Jonathan Wakely a écrit : > > > On Thu, 1 Jun

Re: [PATCH] Move std::search into algobase.h

2023-06-01 Thread Jonathan Wakely via Gcc-patches
On Thu, 1 Jun 2023 at 12:52, Rainer Orth wrote: > Jonathan Wakely via Gcc-patches writes: > > > On Wed, 31 May 2023 at 18:39, François Dumont via Libstdc++ < > > libstd...@gcc.gnu.org> wrote: > > > >> libstdc++: Reduce inclusion to > >> > >> > >> Move the std::search definition from stl_algo.h

Re: [PATCH] Move std::search into algobase.h

2023-06-01 Thread Rainer Orth
Jonathan Wakely via Gcc-patches writes: > On Wed, 31 May 2023 at 18:39, François Dumont via Libstdc++ < > libstd...@gcc.gnu.org> wrote: > >> libstdc++: Reduce inclusion to >> >> >> Move the std::search definition from stl_algo.h to stl_algobase.h and use >> the later in . >> >> For consistency

Re: [PATCH] Move std::search into algobase.h

2023-05-31 Thread Jonathan Wakely via Gcc-patches
On Wed, 31 May 2023 at 18:39, François Dumont via Libstdc++ < libstd...@gcc.gnu.org> wrote: > libstdc++: Reduce inclusion to > > > Move the std::search definition from stl_algo.h to stl_algobase.h and use > the later in . > > For consistency also move std::__parallel::search and associated helpe

[PATCH] Move std::search into algobase.h

2023-05-31 Thread François Dumont via Gcc-patches
libstdc++: Reduce inclusion to Move the std::search definition from stl_algo.h to stl_algobase.h and use the later in . For consistency also move std::__parallel::search and associated helpers from to so that std::__parallel::search is accessible along with std::search. libstdc++-v3/Cha