Re: [PATCH] Move reload_completed and other rtl.h globals to crtl structure.

2022-09-27 Thread Jeff Law via Gcc-patches
On 7/10/22 12:19, Roger Sayle wrote: This patch builds upon Richard Biener's suggestion of avoiding global variables to track state/identify which passes have already been run. In the early middle-end, the tree-ssa passes use the curr_properties field in cfun to track this. This patch uses a ne

Re: [PATCH] Move reload_completed and other rtl.h globals to crtl structure.

2022-07-11 Thread Jeff Law via Gcc-patches
On 7/10/2022 12:19 PM, Roger Sayle wrote: This patch builds upon Richard Biener's suggestion of avoiding global variables to track state/identify which passes have already been run. In the early middle-end, the tree-ssa passes use the curr_properties field in cfun to track this. This patch us

Re: [PATCH] Move reload_completed and other rtl.h globals to crtl structure.

2022-07-11 Thread Richard Sandiford via Gcc-patches
I know it'll seem like make-work, but could you put the combine flag in a separate follow-on patch? Reorganising the existing flags (very welcome!) and adding new ones seem like different things. TBH I'm a bit suspicious of the combine flag. What fundamental property holds true after combine tha

RE: [PATCH] Move reload_completed and other rtl.h globals to crtl structure.

2022-07-11 Thread Richard Biener via Gcc-patches
On Mon, 11 Jul 2022, Roger Sayle wrote: > On 11 July 2022 08:20, Richard Biener wrote: > > On Sun, 10 Jul 2022, Roger Sayle wrote: > > > > > This patch builds upon Richard Biener's suggestion of avoiding global > > > variables to track state/identify which passes have already been run. > > > In t

RE: [PATCH] Move reload_completed and other rtl.h globals to crtl structure.

2022-07-11 Thread Roger Sayle
On 11 July 2022 08:20, Richard Biener wrote: > On Sun, 10 Jul 2022, Roger Sayle wrote: > > > This patch builds upon Richard Biener's suggestion of avoiding global > > variables to track state/identify which passes have already been run. > > In the early middle-end, the tree-ssa passes use the curr

Re: [PATCH] Move reload_completed and other rtl.h globals to crtl structure.

2022-07-11 Thread Richard Biener via Gcc-patches
On Sun, 10 Jul 2022, Roger Sayle wrote: > > This patch builds upon Richard Biener's suggestion of avoiding global > variables to track state/identify which passes have already been run. > In the early middle-end, the tree-ssa passes use the curr_properties > field in cfun to track this. This pat

[PATCH] Move reload_completed and other rtl.h globals to crtl structure.

2022-07-10 Thread Roger Sayle
This patch builds upon Richard Biener's suggestion of avoiding global variables to track state/identify which passes have already been run. In the early middle-end, the tree-ssa passes use the curr_properties field in cfun to track this. This patch uses a new rtl_pass_progress int field in crtl t