Re: [PATCH] Move gen_* stubs from defaults.h to genflags

2015-06-15 Thread Richard Sandiford
Mikhail Maltsev writes: > On 10.06.2015 10:05, Richard Sandiford wrote: >>> +/* Structure which holds data, required for generating stub gen_* >>> function. */ >> >> No comma after "data" >> >>> +/* These instructions require default stub function. Stubs are never >>> called. >> >> "require

Re: [PATCH] Move gen_* stubs from defaults.h to genflags

2015-06-14 Thread Mikhail Maltsev
On 10.06.2015 10:05, Richard Sandiford wrote: >> +/* Structure which holds data, required for generating stub gen_* function. >> */ > > No comma after "data" > >> +/* These instructions require default stub function. Stubs are never >> called. > > "require a default" > [snip] > Seems like t

Re: [PATCH] Move gen_* stubs from defaults.h to genflags

2015-06-10 Thread Trevor Saunders
On Wed, Jun 10, 2015 at 07:28:10AM +0300, Mikhail Maltsev wrote: > Hi, all. > > I noticed that defaults.h file contains stub generator functions which > simply call gcc_unreachable. FWIW, Trevor added them to remove some > conditional compilation which depends on HAVE_ macros (I mean > something l

Re: [PATCH] Move gen_* stubs from defaults.h to genflags

2015-06-10 Thread Richard Sandiford
Richard Sandiford writes: > There again, this is a generator, so those kinds of concerns aren't > particularly important. If we do keep the above though, I think we > should put the hasher in hash-map-table.h now. Of course I mean hash-map-traits.h :-)

Re: [PATCH] Move gen_* stubs from defaults.h to genflags

2015-06-10 Thread Richard Sandiford
Mikhail Maltsev writes: > Hi, all. > > I noticed that defaults.h file contains stub generator functions which > simply call gcc_unreachable. FWIW, Trevor added them to remove some > conditional compilation which depends on HAVE_ macros (I mean > something like r223624). > > Because we still have ~

[PATCH] Move gen_* stubs from defaults.h to genflags

2015-06-09 Thread Mikhail Maltsev
Hi, all. I noticed that defaults.h file contains stub generator functions which simply call gcc_unreachable. FWIW, Trevor added them to remove some conditional compilation which depends on HAVE_ macros (I mean something like r223624). Because we still have ~80 more such conditions in GCC, and pro