Re: [PATCH] Memory leak in parallel/unique_copy

2014-07-03 Thread Jonathan Wakely
On 03/07/14 13:40 +0100, Goncalo Carvalho wrote: Hi, Many thanks! I'll try add a test to the suite (unsure how foolproof will be in terms of detecting memory usage). Yes, it might not be worth adding to the testsuite, but I want to be able to verify the patch changes something :-) The 11000

Re: [PATCH] Memory leak in parallel/unique_copy

2014-07-03 Thread Goncalo Carvalho
Hi, Many thanks! I'll try add a test to the suite (unsure how foolproof will be in terms of detecting memory usage). The 11000 is simply to go beyond the minimum unique_count needed to specialise the parallel version. This was on g++ (GCC) 4.4.5 20110214 (Red Hat 4.4.5-6) but the issue still exis

Re: [PATCH] Memory leak in parallel/unique_copy

2014-07-03 Thread Jonathan Wakely
On 02/07/14 22:42 +0100, Goncalo Carvalho wrote: Hi, In parallel/unique_copy.h __counter is never deleted. I'm also trying to follow from other posts how to submit a patch but is well possible I missed some of the conventions. Many apologies if that's the case. Thanks for this, it looks corre

[PATCH] Memory leak in parallel/unique_copy

2014-07-02 Thread Goncalo Carvalho
Hi, In parallel/unique_copy.h __counter is never deleted. I'm also trying to follow from other posts how to submit a patch but is well possible I missed some of the conventions. Many apologies if that's the case. libstdc++-v3/ * include/parallel/unique_copy.h: prevent memory leak of __counter