Re: [PATCH] Mark -fstack-protect as optimization flag (PR middle-end/71585)

2016-06-30 Thread Martin Liška
On 06/29/2016 01:00 PM, Richard Biener wrote: > Ok. Might want to backport the inline_call hunk to all affected branches. > > Richard. Done in GCC-6 branch. Older branches are not affected.

Re: [PATCH] Mark -fstack-protect as optimization flag (PR middle-end/71585)

2016-06-29 Thread Richard Biener
On Wed, Jun 29, 2016 at 12:29 PM, Martin Liška wrote: > On 06/29/2016 12:27 PM, Martin Liška wrote: >> On 06/29/2016 11:12 AM, Richard Biener wrote: >>> So what was your original reason to pursue this? >>> >>> Richard. >> >> Agree with you that handling the option during inlining is a bit overkill

Re: [PATCH] Mark -fstack-protect as optimization flag (PR middle-end/71585)

2016-06-29 Thread Martin Liška
On 06/29/2016 12:27 PM, Martin Liška wrote: > On 06/29/2016 11:12 AM, Richard Biener wrote: >> So what was your original reason to pursue this? >> >> Richard. > > Agree with you that handling the option during inlining is a bit overkill. > I can live with just marking the option as Optimize, which

Re: [PATCH] Mark -fstack-protect as optimization flag (PR middle-end/71585)

2016-06-29 Thread Martin Liška
On 06/29/2016 11:12 AM, Richard Biener wrote: > So what was your original reason to pursue this? > > Richard. Agree with you that handling the option during inlining is a bit overkill. I can live with just marking the option as Optimize, which will fix reported PR. Sending simplified version 2.

Re: [PATCH] Mark -fstack-protect as optimization flag (PR middle-end/71585)

2016-06-29 Thread Richard Biener
On Wed, Jun 29, 2016 at 11:02 AM, Martin Liška wrote: > On 06/28/2016 03:54 PM, Richard Biener wrote: >> I wonder about the inliner change. If one marks a single function >> with -fstack-protector >> that implicitely marks callers with -fno-stack-protector. So I'd >> rather disable inlining >> b

Re: [PATCH] Mark -fstack-protect as optimization flag (PR middle-end/71585)

2016-06-29 Thread Martin Liška
On 06/28/2016 03:54 PM, Richard Biener wrote: > I wonder about the inliner change. If one marks a single function > with -fstack-protector > that implicitely marks callers with -fno-stack-protector. So I'd > rather disable inlining > between different settings here? It works in the opposite way,

Re: [PATCH] Mark -fstack-protect as optimization flag (PR middle-end/71585)

2016-06-28 Thread Richard Biener
On Tue, Jun 28, 2016 at 3:38 PM, Martin Liška wrote: > Hello. > > Following patch marks -fstack-protect as Optimization flag. > That let a user to mark a function with #pragma GCC optimize > ("-fno-stack-protector") > to disable the optimization for a function. > > Patch survives regression tests

[PATCH] Mark -fstack-protect as optimization flag (PR middle-end/71585)

2016-06-28 Thread Martin Liška
Hello. Following patch marks -fstack-protect as Optimization flag. That let a user to mark a function with #pragma GCC optimize ("-fno-stack-protector") to disable the optimization for a function. Patch survives regression tests and bootstraps on x86_64-linux-gnu. Ready to install? Thanks, Mart