Hi.
Honza can you please take a look at this, because Richi installed patch
that I originally suggested and you were not happy about: r251333.
Thanks,
Martin
ee can
>>>> change semantics
>>>> when no explicit attribute is present is sloppy. I am not sure how many
>>>> programs rely on it
>>>> (it is kind of surprising to see functions not being inlined into your
>>>> target attribute ann
> > - /* If callee has no option attributes, then it is ok to inline. */
> > - if (!callee_tree)
> > + /* If callee has no option attributes (or default),
> > + then it is ok to inline. */
> > + if (!callee_tree || callee_tree == target_option_default_node)
>
> >>
Honza?
Thanks,
Martin
On 06/30/2017 03:50 PM, Martin Liška wrote:
> On 06/28/2017 05:18 PM, Jan Hubicka wrote:
>>> On 06/28/2017 04:24 PM, Jan Hubicka wrote:
> - /* If callee has no option attributes, then it is ok to inline. */
> - if (!callee_tree)
> + /* If callee has no option
into your target
> attribute annotated
> function I guess).
> Note that we check for original file in inliner already - this can be done by
> comparing lto_file_data
> of corresponding cgraph nodes.
>
> Honza
>
>From c07dd3f079382dca617f1a2c32b83f7eaa1797f9 Mon Sep 17 00:00:00 2001
From: marxin
> On 06/28/2017 04:24 PM, Jan Hubicka wrote:
> >> - /* If callee has no option attributes, then it is ok to inline. */
> >> - if (!callee_tree)
> >> + /* If callee has no option attributes (or default),
> >> + then it is ok to inline. */
> >> + if (!callee_tree || callee_tree == target_op
On 06/28/2017 04:24 PM, Jan Hubicka wrote:
>> - /* If callee has no option attributes, then it is ok to inline. */
>> - if (!callee_tree)
>> + /* If callee has no option attributes (or default),
>> + then it is ok to inline. */
>> + if (!callee_tree || callee_tree == target_option_default
> - /* If callee has no option attributes, then it is ok to inline. */
> - if (!callee_tree)
> + /* If callee has no option attributes (or default),
> + then it is ok to inline. */
> + if (!callee_tree || callee_tree == target_option_default_node)
I am not sure this actually makes sense,
Hi.
Following patch makes non-LTO and LTO mode to behave same.
Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
The test-case works on x86_64-linux-gnu.
Ready to be installed?
Martin
gcc/testsuite/ChangeLog:
2017-06-28 Martin Liska
PR target/71991
*
